chore(snmp_zbx): update templates and remove dashboard-related YAML fields #1336
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SNMP Zabbix plugin templates to be compatible with Categraf by removing dashboard-related structures from the Go template definitions and simplifying YAML templates by removing DEPENDENT items in favor of direct SNMP_AGENT items.
Key Changes:
- Removed
Dashboard,DashboardPage, andWidgetstructs from template.go - Replaced full-featured Zabbix templates with simplified "Compatible" versions for Windows, Linux, and Huawei devices
- Converted discovery rules to use
walk[]SNMP OIDs withSNMP_WALK_TO_JSONpreprocessing instead of DEPENDENT item types
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| inputs/snmp_zabbix/template.go | Removed dashboard-related struct definitions (Dashboard, DashboardPage, Widget) and the Dashboards field from Template struct |
| conf/zbx_templates/os/windows_snmp/template_os_windows_snmp.yaml | Replaced comprehensive Windows SNMP template with simplified compatible version, removing DEPENDENT items, triggers, graphs, and dashboards |
| conf/zbx_templates/os/linux_snmp_snmp/template_os_linux_snmp_snmp.yaml | Replaced comprehensive Linux SNMP template with simplified compatible version, removing DEPENDENT items, CPU discovery, block device discovery, and complex preprocessing |
| conf/zbx_templates/net/huawei_snmp/template_net_huawei_snmp.yaml | Replaced comprehensive Huawei VRP SNMP template with simplified compatible version, streamlining discovery rules and removing advanced features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type: SNMP_AGENT | ||
| snmp_oid: '1.3.6.1.2.1.2.2.1.8.{#SNMPINDEX}' | ||
| key: 'net.if.status[{#IFNAME}]' | ||
|
|
There was a problem hiding this comment.
Missing value_type field for the operational status item. This item should likely have a value_type specified (e.g., UNSIGNED or FLOAT) to properly store the SNMP status value.
| value_type: UNSIGNED |
| type: SNMP_AGENT | ||
| snmp_oid: .1.3.6.1.2.1.2.2.1.8.{#SNMPINDEX} | ||
| key: 'net.if.status[{#IFDESCR}]' | ||
|
|
There was a problem hiding this comment.
Missing value_type field for the operational status item. This item should likely have a value_type specified (e.g., UNSIGNED or FLOAT) to properly store the SNMP status value.
| value_type: UNSIGNED |
1 participant
No description provided.