allow background relay requests in getPayloadV2 #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharath-123
reviewed
Nov 10, 2025
server/get_payload.go
Outdated
| // Create a context with a timeout as configured in the http client | ||
| requestCtx, requestCtxCancel := context.WithTimeout(context.Background(), m.httpClientGetPayload.Timeout) | ||
| defer requestCtxCancel() | ||
| originalVersionToUse := versionToUse |
Collaborator
There was a problem hiding this comment.
don't use an originalVersionToUse here. Each relay request is a separate go-routine and we need to handle each separately.
I think we just don't call requestCtxCancel at this point and let the other requests run.
faheelsattar
force-pushed
the
faheel/v2-payload-send-all
branch
from
08b7326 to
6011a60
Compare
jtraglia
reviewed
Nov 10, 2025
server/get_payload.go
Outdated
| // falling back to the V1 API, falling back to the V1 API in the case of any error | ||
| // can be beneficial to the proposer to avoid a missed slot. | ||
| if resp.StatusCode >= http.StatusBadRequest && url == relay.GetURI(params.PathGetPayloadV2) { | ||
| log.Warn("relay may not support V2 API, Retrying with V1 API") |
Collaborator
There was a problem hiding this comment.
The capitalized "Retrying" word should be lowercase.
Suggested change
| log.Warn("relay may not support V2 API, Retrying with V1 API") | |
| log.Warn("relay may not support V2 endpoint, retrying with V1 endpoint") |
Collaborator
There was a problem hiding this comment.
Or this if you prefer:
Suggested change
| log.Warn("relay may not support V2 API, Retrying with V1 API") | |
| log.Warn("relay may not support getPayloadV2, retrying with getPayloadV1") |
jtraglia
reviewed
Nov 10, 2025
| // can be beneficial to the proposer to avoid a missed slot. | ||
| if resp.StatusCode >= http.StatusBadRequest && url == relay.GetURI(params.PathGetPayloadV2) { | ||
| log.Warn("relay may not support V2 API, Retrying with V1 API") | ||
| // retry with v1 api |
Collaborator
There was a problem hiding this comment.
Just a nit, you say "V1 API" (uppercase) in the comments above. A bit consistent.
jtraglia
approved these changes
Nov 10, 2025
Collaborator
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
LGTM, but maybe fix the little warning message nit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR allows sending
getPayloadV2endpoint to all relays by allowing relay requests to continue in the background after receiving the first successful response.This PR also involves improving the logging around MEV-Boost:
✅ I have run these commands
make lintmake test-racego mod tidy