Skip to content

update milestone-2 PR#81

Merged
metachris merged 1 commit intothegostep/milestone-2from
milestone2-cleanup
Apr 4, 2022
Merged

update milestone-2 PR#81
metachris merged 1 commit intothegostep/milestone-2from
milestone2-cleanup

Conversation

@metachris
Copy link
Collaborator

@metachris metachris commented Apr 2, 2022 •
edited
Loading

This PR updates #34

  • remove changes to README and milestone1
  • update sequence diagrams to use supported mermaid syntax, and remove execution_client calls

@metachris metachris requested review from come-maiz and thegostep April 2, 2022 18:31
@metachris metachris force-pushed the milestone2-cleanup branch from dfbcb6e to 42dc9fb Compare April 2, 2022 18:36
@metachris metachris changed the title remove changes to readme and milestone1 update milestone-2 PR Apr 2, 2022
@metachris metachris force-pushed the milestone2-cleanup branch 3 times, most recently from e446094 to f925de4 Compare April 2, 2022 19:07
@metachris metachris force-pushed the milestone2-cleanup branch from f925de4 to 2295220 Compare April 2, 2022 19:33
@come-maiz
Copy link
Contributor

come-maiz commented Apr 4, 2022 •
edited
Loading

Thanks @metachris!
I think we should merge this one as is, as an initial draft, close #34, and start discussing individual concerns as issues.

@metachris metachris merged commit 895e6c5 into thegostep/milestone-2 Apr 4, 2022
@metachris metachris deleted the milestone2-cleanup branch April 4, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thegostep thegostep Awaiting requested review from thegostep

1 more reviewer

@come-maiz come-maiz come-maiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@metachris @come-maiz