Fulu support for mev-boost #805

bharath-123 · 2025-07-01T14:30:40Z

📝 Summary

This PR contains the changes required for the upcoming Fulu hard fork.
These changes have been tested locally against rustic-builder using kurtosis

⛱ Motivation and Context

We need to still merge the fulu changes in github.com/jtraglia/go-builder-client to main before merging this.

📚 References

✅ I have run these commands

make lint
make test-race
go mod tidy

…rath/fulu

jtraglia

Thanks @bharath-123! Looks great. Just a few very small nits.

jtraglia · 2025-07-11T15:05:35Z

common/common.go

+	FieldElementsPerBlob = 4096
+	// BlobExpansionFactor is the factor by which we extend a blob for PeerDas.
+	BlobExpansionFactor = 2
+	// FieldElementsPerCell is the number of field elements in a cell


Suggested change

// FieldElementsPerCell is the number of field elements in a cell

// FieldElementsPerCell is the number of field elements in a cell.

jtraglia · 2025-07-11T15:07:05Z

server/get_payload.go

+	}
+
+	if request.Version >= spec.DataVersionFulu {


Just a nit, I'd remove this blank line. This would be consistent with the commitments & blobs checks.

do you mean the blank line in like 373?

Yes, that's right.

jtraglia · 2025-07-11T15:09:50Z

common/common.go

 	SlotTimeSecMainnet = 12
+	// FieldElementsPerBlob is the number of field elements needed to represent a blob.
+	FieldElementsPerBlob = 4096
+	// BlobExpansionFactor is the factor by which we extend a blob for PeerDas.


Suggested change

// BlobExpansionFactor is the factor by which we extend a blob for PeerDas.

// BlobExpansionFactor is the factor by which we extend a blob for PeerDAS.

jtraglia · 2025-07-11T15:15:09Z

@metachris is on vacation for the next few weeks.

I will merge this after we get approvals from at least 2 of the following:

faheelsattar

looks good!

MariusVanDerWijden · 2025-07-14T10:10:10Z

go.mod

 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
+
+replace github.com/attestantio/go-builder-client => github.com/jtraglia/go-builder-client v0.4.6-0.20250410195459-42a3ff7f1546


Do you want to maintain this for the long term @jtraglia ?

No. We will remove this when attestant adds support. I don't think we have to block merging this PR on that though.

MariusVanDerWijden · 2025-07-14T15:55:59Z

server/get_payload.go

+			log.WithFields(logrus.Fields{
+				"requestBlobCommitments": len(requestCommitments),
+				"responseProofs":         len(responseProofs),
+			}).Error("different lengths for proofs")


Suggested change

}).Error("different lengths for proofs")

}).Error("wrong lengths for proofs")

Nitpicky, but I would change all "different" to "wrong"

MariusVanDerWijden · 2025-07-14T15:57:22Z

server/get_payload.go

-		len(requestCommitments) != len(responseBlobsBundle.Commitments) ||
-		len(requestCommitments) != len(responseBlobsBundle.Proofs) {
+	// Check commitments
+	responseCommitments, err := responseBlobsBundle.Commitments()


you could still verify blobs here, would save a bit of duplicated code

MariusVanDerWijden · 2025-07-14T16:04:17Z

server/get_payload.go

+			block := new(eth2ApiV1Deneb.SignedBlindedBeaconBlock)
+			if err = json.Unmarshal(in, block); err != nil {
+				return err
+			}
+			out.Version = spec.DataVersionDeneb
+			out.Deneb = block


This whole api is so cursed. out should just have a type block any

Lol. I don't think making it any would be a wise change. It's okay to be explicit.

I know, the correct way would be an interface that all the different types implement.
Making it explicit is just super ugly.

edit: just how we implement transactions in geth

agree, that'd be nice! perhaps open an issue to remind us of it later and we do a follow-up PR for this?

MariusVanDerWijden · 2025-07-14T17:39:41Z

server/service_test.go

+	numBlobs := len(kzgCommitments)
+	commitments := make([]deneb.KZGCommitment, numBlobs)
+	copy(commitments, kzgCommitments)
+	// For testing, proofs and blobs are not populated


it would be a good idea to have some default values

MariusVanDerWijden · 2025-07-14T17:47:13Z

server/service_test.go

+	commitments := make([]deneb.KZGCommitment, numBlobs)
+	copy(commitments, kzgCommitments)
+	// For testing, proofs and blobs are not populated
+	proofs := make([]deneb.KZGProof, numBlobs)


Shouldn't this be numBlobs* CellsPerExtBlob

Faheelsattar/v2 get payload

jtraglia

LGTM, thanks @bharath-123 & @faheelsattar!

Copilot

Pull Request Overview

This PR adds support for the Fulu hard fork to mev-boost, which is an upcoming Ethereum hard fork. The changes implement the necessary modifications to handle Fulu-specific data structures and API endpoints throughout the codebase.

Adds Fulu consensus version constants and handling across all relevant functions
Implements a new V2 endpoint for payload submission that doesn't return the execution payload
Updates blob verification logic to support the new cell-based proof structure in Fulu

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
testdata/signed-blinded-beacon-block-fulu.json	Adds test data for Fulu fork validation
server/utils.go	Extends payload validation to include Fulu version checks
server/service_test.go	Adds comprehensive tests for V2 endpoint and Fulu support
server/service.go	Implements the new handleGetPayloadV2 endpoint
server/params/paths.go	Defines the V2 endpoint path constant
server/mock/mock_relay.go	Extends mock relay to support V2 endpoint testing
server/get_payload.go	Major refactoring to support both V1/V2 endpoints and Fulu verification
server/get_header.go	Adds Fulu version handling for header operations
server/constants.go	Defines Fulu consensus version constant
go.mod	Updates dependencies with custom forks for Fulu support
common/common.go	Adds PeerDAS-related constants for blob cell calculations

server/service_test.go

server/get_payload.go

metachris · 2025-08-08T09:46:44Z

server/service.go

 	}
 }

+// Deprecated: For reference: https://github.com/ethereum/builder-specs/issues/119


nice, thanks for that

server/get_payload.go

metachris · 2025-08-08T09:52:31Z

server/get_payload.go

 	m.bidsLock.Unlock()
 	if originalBid.response.IsEmpty() {
-		log.Error("no bid for this getPayload payload found, was getHeader called before?")
+		log.Error("no bid for this payload found, was getHeader called before?")


Suggested change

log.Error("no bid for this payload found, was getHeader called before?")

log.Warn("no bid for this payload found, was getHeader called before?")

a warn is better here, and it's common for this to happen in DV setups

jtraglia and others added 9 commits April 22, 2025 10:12

Initial fulu support

9726e44

Fix lint and some nits

39b6701

Update go-eth2-client

0fc7320

Add fulu test & fix tests

d024021

Merge branch 'fulu' of https://github.com/jtraglia/mev-boost into bha…

89c1d4a

…rath/fulu

update go-eth2-client

08e9d5c

Merge pull request #1 from bharath-123/bharath/fulu

eef602e

ensure that number of commitments equals extended blob cell proofs

481f298

fmt

b8753f7

bharath-123 marked this pull request as ready for review July 1, 2025 14:31

bharath-123 marked this pull request as draft July 1, 2025 14:31

bharath-123 force-pushed the bharath/fulu branch from 630bdad to b8753f7 Compare July 1, 2025 14:43

bharath-123 marked this pull request as ready for review July 11, 2025 07:43

jtraglia previously approved these changes Jul 11, 2025

View reviewed changes

jtraglia requested review from MariusVanDerWijden and ralexstokes July 11, 2025 15:15

minor typos

866b905

bharath-123 dismissed jtraglia’s stale review via 866b905 July 14, 2025 05:49

bharath-123 mentioned this pull request Jul 14, 2025

feat: Add Fusaka support for MEV-Boost relay flashbots/mev-boost-relay#745

Merged

4 tasks

faheelsattar approved these changes Jul 14, 2025

View reviewed changes

MariusVanDerWijden reviewed Jul 14, 2025

View reviewed changes

bharath-123 and others added 3 commits July 15, 2025 09:35

address some review comments

eb43547

add blobs, commitments and cell proofs to fulu payload tests

acb775d

add support for v2 blinded blocks

5e00dcc

faheelsattar and others added 7 commits July 22, 2025 18:25

resolve comments

0fcdc83

update name

746cd0d

add common function

c8eb8ae

add tests

50ae7b4

address comments

f76a9ac

clean logs

b7b6d90

Merge pull request #2 from faheelsattar/faheelsattar/v2-get-payload

45c82c3

Faheelsattar/v2 get payload

jtraglia previously approved these changes Jul 24, 2025

View reviewed changes

jtraglia dismissed their stale review via 848f644 July 24, 2025 13:07

jtraglia previously approved these changes Jul 24, 2025

View reviewed changes

bharath-123 dismissed jtraglia’s stale review via 18b99ba August 6, 2025 12:45

bharath-123 force-pushed the bharath/fulu branch from 848f644 to 18b99ba Compare August 6, 2025 12:45

minor refactoring

a07eaf1

bharath-123 force-pushed the bharath/fulu branch from 18b99ba to a07eaf1 Compare August 6, 2025 13:56

remove unecessary consts

28b0582

metachris requested a review from Copilot August 8, 2025 09:26

Copilot AI reviewed Aug 8, 2025

View reviewed changes

server/service_test.go Show resolved Hide resolved

server/get_payload.go Show resolved Hide resolved

metachris reviewed Aug 8, 2025

View reviewed changes

server/get_payload.go Show resolved Hide resolved

metachris reviewed Aug 8, 2025

View reviewed changes

fix lint issues

58b4935

metachris previously approved these changes Aug 13, 2025

View reviewed changes

bharath-123 dismissed metachris’s stale review via cf98ebd August 13, 2025 16:04

fix CI issues

4aaea35

bharath-123 force-pushed the bharath/fulu branch from cf98ebd to 4aaea35 Compare August 13, 2025 16:08

fix CI issues

8a07d50

jtraglia approved these changes Aug 13, 2025

View reviewed changes

jtraglia merged commit 876c490 into flashbots:develop Aug 13, 2025
2 of 3 checks passed

	// FieldElementsPerCell is the number of field elements in a cell
	// FieldElementsPerCell is the number of field elements in a cell.

	// BlobExpansionFactor is the factor by which we extend a blob for PeerDas.
	// BlobExpansionFactor is the factor by which we extend a blob for PeerDAS.

	}).Error("different lengths for proofs")
	}).Error("wrong lengths for proofs")

	log.Error("no bid for this payload found, was getHeader called before?")
	log.Warn("no bid for this payload found, was getHeader called before?")

Fulu support for mev-boost #805

Fulu support for mev-boost #805

Uh oh!

Conversation

bharath-123 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

⛱ Motivation and Context

📚 References

✅ I have run these commands

Uh oh!

jtraglia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtraglia commented Jul 11, 2025

Uh oh!

faheelsattar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MariusVanDerWijden Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtraglia left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bharath-123 commented Jul 1, 2025 •

edited

Loading

MariusVanDerWijden Jul 14, 2025 •

edited

Loading