[2.x] fix: delete avatar file from disk when user account is deleted#4485
Merged
Conversation
AvatarUploader::remove() was never called during user deletion, leaving avatar files as orphans on the flarum-avatars disk. Every deleted user with a custom avatar accumulated a stranded file indefinitely. Hook into the existing deleting observer (pre-delete, so the avatar_url attribute is still readable) and delete the file directly from the filesystem. Uses getRawOriginal() to get the stored path rather than the accessor, which would return a full URL. Fixes #4459
imorland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4459.
When a user account was deleted, their avatar file was never cleaned up from the
flarum-avatarsdisk.AvatarUploader::remove()was only called via the explicit avatar delete flow — not during user account deletion. Over time this accumulates orphaned files with no recovery path.Fix
Hook into the existing
deletingobserver inUser::boot()(pre-delete, soavatar_urlis still readable) and delete the file directly from the filesystem using the sameresolve(Factory::class)->disk('flarum-avatars')pattern already used in the model.Using
deletingrather thandeletedis intentional — by the timedeletedfires the model attributes may no longer reflect the original DB state.getRawOriginal('avatar_url')reads the stored path rather than going through the accessor (which would return a full URL).Test plan
flarum-avatarsstorage