[2.x] fix(core): skip password check on update page for passwordless drivers#4435
Merged
imorland merged 3 commits intoMar 14, 2026
Merged
Conversation
…se drivers SQLite does not store a password in config, so the strict comparison `databasePassword !== null` always fails. This conditionally skips the password form and validation when no password is configured.
datlechin
changed the title
imorland
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The update page always asks for a database password, but SQLite (and any driver without credentials) never stores a
passwordkey in config. This causes the strict comparison to always fail since"" !== null.