Repository navigation
test: Update game_widget_lifecycle_test for material_ui 1.8.0 - #4125
Merged
spydon merged 3 commits intoOct 21, 2026
Merged
Conversation
This was referenced Oct 20, 2026
auto-submit Bot
pushed a commit
to flutter/tests
that referenced
this pull request
Oct 20, 2026
`material_ui` 1.8.0 (flutter/packages#13161) enabled route-transition raster snapshotting ([`allowSnapshotting = true`](https://github.com/flutter/packages/blob/623479c2ee9209316460eafb3f3cff61367127a0/packages/material_ui/lib/src/page_transitions_theme.dart#L590-L607)) in `FadeForwardsPageTransitionsBuilder`, causing `game_widget_lifecycle_test.dart` in `flame.test` to fail because `SnapshotWidget` reuses the cached route raster instead of calling `GameRenderBox.paint` a second time during the transition. Example CI failures: - https://ci.chromium.org/b/8667404745333857041 - https://ci.chromium.org/b/8667406041351366033 This temporarily disables `flame.test` to unblock the `flutter/flutter` tree while flame-engine/flame#4125 lands. Part of flutter/flutter#194883
justinmc
reviewed
Oct 20, 2026
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me as the author of flutter/packages#13161. Another option would be to manually disable snapshotting (FadeForwardsTransitionsBuilder.allowSnapshotting = false) if that works better for Flame. Any animations running in the route will freeze during the transition if snapshotting is enabled.
Member
@mdebbar this sounds like a better option. |
spydon
approved these changes
Oct 21, 2026
spydon
enabled auto-merge (squash)
October 21, 2026 08:14
auto-submit Bot
pushed a commit
to flutter/tests
that referenced
this pull request
Oct 21, 2026
Follow-up to #508. flame-engine/flame#4125 (`69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`) updated `game_widget_lifecycle_test.dart` in `flame-engine/flame` to disable route-transition snapshotting (`FadeForwardsPageTransitionsBuilder(allowSnapshotting: false)`) for `material_ui` 1.8.0. This re-enables `registry/flame.test` and updates the pinned `flame` revision to `69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`. Part of flutter/flutter#194883
opensource-fork-sync Bot
pushed a commit
to cla7aye15I4nd/opensource-flutter__flutter
that referenced
this pull request
Oct 21, 2026
Follow-up to flutter#194886. flame-engine/flame#4125 (`69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`) updated `game_widget_lifecycle_test.dart` in `flame-engine/flame` for `material_ui` 1.8.0, and flutter/tests#509 (`39874535bcc16e86286fa634e0479c0ec85ce1ae`) re-enabled `registry/flame.test` in `flutter/tests`. This rolls `dev/customer_testing/tests.version` to `39874535bcc16e86286fa634e0479c0ec85ce1ae`. Fixes flutter#194883
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Oct 22, 2026
Follow-up to flutter#194886. flame-engine/flame#4125 (`69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`) updated `game_widget_lifecycle_test.dart` in `flame-engine/flame` for `material_ui` 1.8.0, and flutter/tests#509 (`39874535bcc16e86286fa634e0479c0ec85ce1ae`) re-enabled `registry/flame.test` in `flutter/tests`. This rolls `dev/customer_testing/tests.version` to `39874535bcc16e86286fa634e0479c0ec85ce1ae`. Fixes flutter#194883
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
Follow-up to flutter#194886. flame-engine/flame#4125 (`69b0968f97e3fdc07b3f19a44ba0df5a01a53d04`) updated `game_widget_lifecycle_test.dart` in `flame-engine/flame` for `material_ui` 1.8.0, and flutter/tests#509 (`39874535bcc16e86286fa634e0479c0ec85ce1ae`) re-enabled `registry/flame.test` in `flutter/tests`. This rolls `dev/customer_testing/tests.version` to `39874535bcc16e86286fa634e0479c0ec85ce1ae`. Fixes flutter#194883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
material_ui1.8.0 (flutter/packages#13161) enabled route-transition raster snapshotting (allowSnapshotting = true) inFadeForwardsPageTransitionsBuilderon Android, matchingZoomPageTransitionsBuilder.In
game_widget_lifecycle_test.dart, whentester.tap(find.text('Play'))pumps a second frame 16ms into the/gameroute transition,SnapshotWidgetreuses the raster snapshot captured on the first transition frame instead of callingGameRenderBox.painta second time.Example CI failures:
This disables route-transition snapshotting via
FadeForwardsPageTransitionsBuilder(allowSnapshotting: false)in_MyAppso the game continues rendering live during the transition.Part of flutter/flutter#194883