Repository navigation
fix: Workaround for the TextBoxComponent entering an endless loop - #3939
Merged
Merged
Conversation
spydon
approved these changes
Jul 1, 2026
4 of 5 tasks
spydon
added a commit
that referenced
this pull request
Oct 1, 2026
The rich text document pipeline (`DocumentRoot`, `ParagraphNode`, `HeaderNode`, and therefore `flame_markdown`) was the last place in Flame that broke lines itself. Its layout builder split on ASCII spaces, re-measured every tentative line with a fresh `TextPainter`, could not wrap CJK, threw on `TextAlign.justify`, lost kerning and ligatures at span boundaries, and needed glue heuristics for punctuation that were patched again in #4060 after #3192 and #3939. Since `InlineTextStyle` always renders through `TextPaint`, that pipeline can hand the whole block to Flutter's paragraph engine without losing any capability: - `InlineTextNode.layoutBuilder` is replaced by `InlineSpan toInlineSpan()`. `PlainTextNode` and `GroupTextNode` build a `TextSpan` tree, the wrapper nodes delegate to their child. - `TextBlockNode.format` lays out one `TextPainter` per block and returns the new `ParagraphTextElement`, which exposes `lines` and `lineMetrics`. Justify, CJK wrapping, hard line breaks, and shaping across differently styled spans now work. - `TextElement` gained a no-op `dispose()`, forwarded by `GroupElement`, which `ParagraphTextElement` uses to release its painter. - `TextBoxComponent` lays out a dedicated painter for wrapping and reads lines through `ParagraphTextElement`. It previously called `layout(maxWidth:)` on the painter shared through the `TextPaint` cache, so the wrapped layout leaked into later `format` calls for the same string. Per-line rendering, `align`, `growingBox` and the typewriter effect are unchanged. --------- Co-authored-by: Luan Nico <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an workaround for and issue that was cause the
TextBoxComponententer a never ending loop when rendering some texts.This is being cause due the result
TextRangefrom theTextPaintersometimes reporting an incorrect result, very mostly likely because of the floating number innacuracy in javascript.An issue was open in the Flutter repository to track this issue: flutter/flutter#188874
This workaround could be removed/revisited depending on the outcome of such issue.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #3938