Skip to content

Attempt to trigger ci for RISC-V#733

Closed
angsch wants to merge 4 commits intoflame:riscvfrom
angsch:trigger-ci
Closed

Attempt to trigger ci for RISC-V#733
angsch wants to merge 4 commits intoflame:riscvfrom
angsch:trigger-ci

Conversation

@angsch
Copy link
Copy Markdown
Collaborator

@angsch angsch commented Mar 25, 2023

Squashed PR

fgvanzee and others added 3 commits March 24, 2023 20:05
Details:
- Updated common.mk so that when --disable-shared option is given to
  configure:
  1. The -fPIC compiler flag is omitted from the individual 
     configuration family members' CPICFLAGS variables (which are 
     initialized in each subconfig's make_defs.mk file); and
  2. The BUILD_SYMFLAGS variable, which contains compiler flags needed 
     to control the symbol export behavior, is left blank.
- The net result of these changes is that flags specific to shared
  library builds are only used when a shared library is actually 
  scheduled to be built. Thanks to Nick Knight for reporting this issue.
- CREDITS file update.
@angsch angsch mentioned this pull request Mar 27, 2023
@fgvanzee
Copy link
Copy Markdown
Member

Oops, sorry. I forgot this is your repository, not flame/blis. 😅 Let me try to trigger on flame/blis now.

@angsch
Copy link
Copy Markdown
Collaborator Author

angsch commented Mar 27, 2023

Travis does not like this PR any more... 😢

@fgvanzee
Copy link
Copy Markdown
Member

Don't worry, we will figure this out.

Sanity check if I can trigger CI the same as Field
@angsch
Copy link
Copy Markdown
Collaborator Author

angsch commented Mar 30, 2023

Closing since outdated

@angsch angsch closed this Mar 30, 2023
@angsch angsch deleted the trigger-ci branch March 30, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants