Fix 1m enablement for herk/her2k/syrk/syr2k. (#743)

devinamatthews · web-flow · commit 89b7863fc9a8 · 2023-05-08T16:51:18.000-05:00
Details: - Ever since 28b0982, herk, her2k, syrk, and syr2k have been implemented in terms of the gemmt expert API. And since the decision of which induced method to use (1m or native) is made *below* the level of the expert API, executing any of {herk,her2k,syrk,syr2k} results in BLIS checking the enablement status for gemmt. - This commit applies a band-aid of sorts to this issue by modifying bli_l3_ind_oper_get_enable() and bli_l3_ind_oper_set_enable() so that any attempts to query or modify the internal enablement status for herk, her2k, syrk, or syr2k instead does so for gemmt. - This solution isn't perfect since, in theory, the user could enable 1m for, say, herk but then disable it for syrk, and then be confused when herk runs via native execution. But we don't anticipate that users modify 1m enablement at the operation level, and so in practice this solution is likely fine for now.
diff --git a/frame/3/bli_l3_ind.c b/frame/3/bli_l3_ind.c
@@ -201,6 +201,18 @@ void bli_l3_ind_oper_set_enable( opid_t oper, ind_t method, num_t dt, bool statu
 	if ( !bli_is_complex( dt ) ) return;
 	if ( !bli_opid_is_level3( oper ) ) return;
 
+	// BLIS currently implements herk/her2k/syrk/syr2k in terms of the user-
+	// level gemmt (expert) API, and so those operations choose to execute
+	// 1m (or not) based on the induced method enablement status of gemmt.
+	// In other words, changing the enablement status of those operations
+	// would have no effect. Therefore, we redirect queries/accesses to those
+	// operations' induced method enablement statuses to that of gemmt.
+	if ( method != BLIS_NAT && ( oper == BLIS_HERK  ||
+	                             oper == BLIS_HER2K ||
+	                             oper == BLIS_SYRK  ||
+	                             oper == BLIS_SYR2K ) )
+		oper = BLIS_GEMMT;
+
 	// Disallow changing status of native execution.
 	if ( method == BLIS_NAT ) return;
 
@@ -224,6 +236,18 @@ bool bli_l3_ind_oper_get_enable( opid_t oper, ind_t method, num_t dt )
 	num_t idt = bli_ind_map_cdt_to_index( dt );
 	bool  r_val;
 
+	// BLIS currently implements herk/her2k/syrk/syr2k in terms of the user-
+	// level gemmt (expert) API, and so those operations choose to execute
+	// 1m (or not) based on the induced method enablement status of gemmt.
+	// In other words, changing the enablement status of those operations
+	// would have no effect. Therefore, we redirect queries/accesses to those
+	// operations' induced method enablement statuses to that of gemmt.
+	if ( method != BLIS_NAT && ( oper == BLIS_HERK  ||
+	                             oper == BLIS_HER2K ||
+	                             oper == BLIS_SYRK  ||
+	                             oper == BLIS_SYR2K ) )
+		oper = BLIS_GEMMT;
+
 	{
 		r_val = bli_l3_ind_oper_st[ method ][ oper ][ idt ];
 	}
