Skip to content

Commit 5a5f494

Browse files
fgvanzeefgvanzee
committed
Removed export macros from all internal prototypes.
Details: - After merging PR #303, at Isuru's request, I removed the use of BLIS_EXPORT_BLIS from all function prototypes *except* those that we potentially wish to be exported in shared/dynamic libraries. In other words, I removed the use of BLIS_EXPORT_BLIS from all prototypes of functions that can be considered private or for internal use only. This is likely the last big modification along the path towards implementing the functionality spelled out in issue #248. Thanks again to Isuru Fernando for his initial efforts of sprinkling the export macros throughout BLIS, which made removing them where necessary relatively painless. Also, I'd like to thank Tony Kelman, Nathaniel Smith, Ian Henriksen, Marat Dukhan, and Matthew Brett for participating in the initial discussion in issue #37 that was later summarized and restated in issue #248. - CREDITS file update.
1 parent 3dc1892 commit 5a5f494

File tree

169 files changed

+730
-666
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

169 files changed

+730
-666
lines changed

‎CREDITS‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@ but many others have contributed code and feedback, including
1414
Erling Andersen @erling-d-andersen
1515
Alex Arslan @ararslan
1616
Vernon Austel (IBM, T.J. Watson Research Center)
17+
Matthew Brett @matthew-brett (University of Birmingham)
1718
Jed Brown @jedbrown (Argonne National Laboratory)
1819
Robin Christ @robinchrist
1920
Kay Dewhurst @jkd2016 (Max Planck Institute, Halle, Germany)
2021
Jeff Diamond (Oracle)
2122
Johannes Dieterich @iotamudelta
2223
Krzysztof Drewniak @krzysz00
24+
Marat Dukhan @Maratyszcza (Google)
2325
Victor Eijkhout @VictorEijkhout (Texas Advanced Computing Center)
2426
Isuru Fernando @isuruf
2527
Roman Gareev @gareevroman
@@ -30,7 +32,7 @@ but many others have contributed code and feedback, including
3032
Jeff Hammond @jeffhammond (Intel)
3133
Jacob Gorm Hansen @jacobgorm
3234
Jean-Michel Hautbois @jhautbois
33-
Ian Henriksen @insertinterestingnamehere
35+
Ian Henriksen @insertinterestingnamehere (The University of Texas at Austin)
3436
Minh Quan Ho @hominhquan
3537
Matthew Honnibal @honnibal
3638
Stefan Husmann @stefanhusmann
@@ -63,6 +65,7 @@ but many others have contributed code and feedback, including
6365
Rene Sitt
6466
Tony Skjellum @tonyskjellum (The University of Tennessee at Chattanooga)
6567
Mikhail Smelyanskiy (Intel, Parallel Computing Lab)
68+
Nathaniel Smith @njsmith
6669
Shaden Smith @ShadenSmith
6770
Tyler Smith @tlrmchlsmth (The University of Texas at Austin)
6871
Paul Springer @springer13 (RWTH-Aachen)
@@ -83,8 +86,10 @@ partners, including
8386

8487
AMD
8588
Hewlett Packard Enterprise
89+
Huawei
8690
Intel
8791
Microsoft
92+
Oracle
8893
Texas Instruments
8994

9095
as well as the National Science Foundation (NSF Awards CCF-0917167,

‎frame/0/bli_l0_check.h‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
#undef GENTPROT
4141
#define GENTPROT( opname ) \
4242
\
43-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
43+
void PASTEMAC(opname,_check) \
4444
( \
4545
obj_t* chi, \
4646
obj_t* psi \
@@ -57,7 +57,7 @@ GENTPROT( subsc )
5757
#undef GENTPROT
5858
#define GENTPROT( opname ) \
5959
\
60-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
60+
void PASTEMAC(opname,_check) \
6161
( \
6262
obj_t* chi \
6363
);
@@ -68,7 +68,7 @@ GENTPROT( invertsc )
6868
#undef GENTPROT
6969
#define GENTPROT( opname ) \
7070
\
71-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
71+
void PASTEMAC(opname,_check) \
7272
( \
7373
obj_t* chi, \
7474
obj_t* absq \
@@ -81,7 +81,7 @@ GENTPROT( normfsc )
8181
#undef GENTPROT
8282
#define GENTPROT( opname ) \
8383
\
84-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
84+
void PASTEMAC(opname,_check) \
8585
( \
8686
obj_t* chi, \
8787
double* zeta_r, \
@@ -94,7 +94,7 @@ GENTPROT( getsc )
9494
#undef GENTPROT
9595
#define GENTPROT( opname ) \
9696
\
97-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
97+
void PASTEMAC(opname,_check) \
9898
( \
9999
double zeta_r, \
100100
double zeta_i, \
@@ -107,7 +107,7 @@ GENTPROT( setsc )
107107
#undef GENTPROT
108108
#define GENTPROT( opname ) \
109109
\
110-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
110+
void PASTEMAC(opname,_check) \
111111
( \
112112
obj_t* chi, \
113113
obj_t* zeta_r, \
@@ -120,7 +120,7 @@ GENTPROT( unzipsc )
120120
#undef GENTPROT
121121
#define GENTPROT( opname ) \
122122
\
123-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
123+
void PASTEMAC(opname,_check) \
124124
( \
125125
obj_t* zeta_r, \
126126
obj_t* zeta_i, \
@@ -132,18 +132,18 @@ GENTPROT( zipsc )
132132

133133
// -----------------------------------------------------------------------------
134134

135-
BLIS_EXPORT_BLIS void bli_l0_xsc_check
135+
void bli_l0_xsc_check
136136
(
137137
obj_t* chi
138138
);
139139

140-
BLIS_EXPORT_BLIS void bli_l0_xxsc_check
140+
void bli_l0_xxsc_check
141141
(
142142
obj_t* chi,
143143
obj_t* psi
144144
);
145145

146-
BLIS_EXPORT_BLIS void bli_l0_xx2sc_check
146+
void bli_l0_xx2sc_check
147147
(
148148
obj_t* chi,
149149
obj_t* norm

‎frame/0/bli_l0_fpa.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
#define GENPROT( opname ) \
4141
\
4242
PASTECH(opname,_vft) \
43-
BLIS_EXPORT_BLIS BLIS_EXPORT_BLIS PASTEMAC(opname,_qfp)( num_t dt );
43+
PASTEMAC(opname,_qfp)( num_t dt );
4444

4545
GENPROT( absqsc )
4646
GENPROT( normfsc )

‎frame/1/bli_l1v_check.h‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
#undef GENTPROT
4141
#define GENTPROT( opname ) \
4242
\
43-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
43+
void PASTEMAC(opname,_check) \
4444
( \
4545
obj_t* x, \
4646
obj_t* y \
@@ -55,7 +55,7 @@ GENTPROT( swapv )
5555
#undef GENTPROT
5656
#define GENTPROT( opname ) \
5757
\
58-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
58+
void PASTEMAC(opname,_check) \
5959
( \
6060
obj_t* x, \
6161
obj_t* index \
@@ -67,7 +67,7 @@ GENTPROT( amaxv )
6767
#undef GENTPROT
6868
#define GENTPROT( opname ) \
6969
\
70-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
70+
void PASTEMAC(opname,_check) \
7171
( \
7272
obj_t* alpha, \
7373
obj_t* x, \
@@ -81,7 +81,7 @@ GENTPROT( axpbyv )
8181
#undef GENTPROT
8282
#define GENTPROT( opname ) \
8383
\
84-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
84+
void PASTEMAC(opname,_check) \
8585
( \
8686
obj_t* alpha, \
8787
obj_t* x, \
@@ -95,7 +95,7 @@ GENTPROT( scal2v )
9595
#undef GENTPROT
9696
#define GENTPROT( opname ) \
9797
\
98-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
98+
void PASTEMAC(opname,_check) \
9999
( \
100100
obj_t* x, \
101101
obj_t* y, \
@@ -108,7 +108,7 @@ GENTPROT( dotv )
108108
#undef GENTPROT
109109
#define GENTPROT( opname ) \
110110
\
111-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
111+
void PASTEMAC(opname,_check) \
112112
( \
113113
obj_t* alpha, \
114114
obj_t* x, \
@@ -123,7 +123,7 @@ GENTPROT( dotxv )
123123
#undef GENTPROT
124124
#define GENTPROT( opname ) \
125125
\
126-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
126+
void PASTEMAC(opname,_check) \
127127
( \
128128
obj_t* x \
129129
);
@@ -134,7 +134,7 @@ GENTPROT( invertv )
134134
#undef GENTPROT
135135
#define GENTPROT( opname ) \
136136
\
137-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
137+
void PASTEMAC(opname,_check) \
138138
( \
139139
obj_t* alpha, \
140140
obj_t* x \
@@ -147,7 +147,7 @@ GENTPROT( setv )
147147
#undef GENTPROT
148148
#define GENTPROT( opname ) \
149149
\
150-
BLIS_EXPORT_BLIS void PASTEMAC(opname,_check) \
150+
void PASTEMAC(opname,_check) \
151151
( \
152152
obj_t* x, \
153153
obj_t* beta, \
@@ -160,35 +160,35 @@ GENTPROT( xpbyv )
160160

161161
// -----------------------------------------------------------------------------
162162

163-
BLIS_EXPORT_BLIS void bli_l1v_xy_check
163+
void bli_l1v_xy_check
164164
(
165165
obj_t* x,
166166
obj_t* y
167167
);
168168

169-
BLIS_EXPORT_BLIS void bli_l1v_axy_check
169+
void bli_l1v_axy_check
170170
(
171171
obj_t* alpha,
172172
obj_t* x,
173173
obj_t* y
174174
);
175175

176-
BLIS_EXPORT_BLIS void bli_l1v_xby_check
176+
void bli_l1v_xby_check
177177
(
178178
obj_t* x,
179179
obj_t* beta,
180180
obj_t* y
181181
);
182182

183-
BLIS_EXPORT_BLIS void bli_l1v_axby_check
183+
void bli_l1v_axby_check
184184
(
185185
obj_t* alpha,
186186
obj_t* x,
187187
obj_t* beta,
188188
obj_t* y
189189
);
190190

191-
BLIS_EXPORT_BLIS void bli_l1v_dot_check
191+
void bli_l1v_dot_check
192192
(
193193
obj_t* alpha,
194194
obj_t* x,
@@ -197,18 +197,18 @@ BLIS_EXPORT_BLIS void bli_l1v_dot_check
197197
obj_t* rho
198198
);
199199

200-
BLIS_EXPORT_BLIS void bli_l1v_x_check
200+
void bli_l1v_x_check
201201
(
202202
obj_t* x
203203
);
204204

205-
BLIS_EXPORT_BLIS void bli_l1v_ax_check
205+
void bli_l1v_ax_check
206206
(
207207
obj_t* alpha,
208208
obj_t* x
209209
);
210210

211-
BLIS_EXPORT_BLIS void bli_l1v_xi_check
211+
void bli_l1v_xi_check
212212
(
213213
obj_t* x,
214214
obj_t* index

‎frame/1/bli_l1v_fpa.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
#define GENPROT( opname ) \
4141
\
4242
PASTECH2(opname,BLIS_TAPI_EX_SUF,_vft) \
43-
BLIS_EXPORT_BLIS BLIS_EXPORT_BLIS PASTEMAC2(opname,BLIS_TAPI_EX_SUF,_qfp)( num_t dt );
43+
PASTEMAC2(opname,BLIS_TAPI_EX_SUF,_qfp)( num_t dt );
4444

4545
GENPROT( addv )
4646
GENPROT( copyv )

0 commit comments

Comments
 (0)