feat: Globby 10 update with fast glob by fisker · Pull Request #120 · fisker/prettier

fisker · 2019-10-31T01:03:15Z

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
(If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
I’ve read the contributing guidelines.

with some minor test snapshot updates in tests_integration since fast-glob does not always keep the same file order as node-glob

use of no `nodir: true` option was introduced in 639c523 but it does not seem to be needed with some newer versions of globby

ref: https://github.com/mrmlnc/fast-glob#how-to-write-patterns-on-windows Co-authored-by: fisker Cheung <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

This reverts commit f7297cb.

and update some snapshots in tests_integration

ref: https://github.com/sindresorhus/globby/blob/master/index.js#L95

# Conflicts: # package.json # yarn.lock

todo · 2019-11-01T02:10:46Z

move `multiple-patterns` tests into this one

prettier/tests_integration/__tests__/patterns.js

Lines 7 to 12 in 1703029

    
           // TODO: move `multiple-patterns` tests into this one 
        
           describe("should support dot pattern", () => { 
        
             runPrettier("cli/multiple-patterns", [".", "-l"]).test({ 
        
               status: 1 
        
             });

This comment was generated by todo based on a `TODO` comment in `1703029` in #120. cc @fisker.

# Conflicts: # yarn.lock

todo · 2019-11-01T06:45:07Z

move `multiple-patterns` tests into this one

prettier/tests_integration/__tests__/patterns.js

Lines 7 to 12 in c1cbe62

    
           // TODO: move `multiple-patterns` tests into this one 
        
           describe("should support dot pattern", () => { 
        
             runPrettier("cli/multiple-patterns", [".", "-l"]).test({ 
        
               status: 1 
        
             });

This comment was generated by todo based on a `TODO` comment in `c1cbe62` in #120. cc @fisker.

# Conflicts: # package.json # tests_integration/__tests__/__snapshots__/patterns.js.snap # tests_integration/__tests__/patterns.js # yarn.lock

pull-assistant · 2020-02-04T13:54:07Z

Best reviewed: commit by commit

Optimal code review plan (16 warnings, 3 commits squashed)

globby@10 update (with fast-glob implementation)

...ts__/multiple-patterns.js.snap 83% changes removed in Merge branch 'next' ...

...with-config-precedence.js.snap 91% changes removed in revert updates to sn...

with no nodir: true option

with workaround for fast-glob on Windows

Revert "with no nodir: true option"

revert updates to snapshots in tests_integration

sort the file paths from globby

src/cli/util.js 50% changes removed in restore snap

Update build scripts

replace `util.promisify` with `pify`

scripts/build/config.js 60% changes removed in typo

exclude transform-async-to-generator

fix bin-prettier.js

restore disabled script

try depth:1

remove depth add ./

sort dir

disable expandDirectories

use absolute path

remove sort()

sort dir

src/common/load-plugins.js 50% changes removed in use alphasorti com...

use alphasorti compare

remove './'

src/common/load-plugins.js 67% changes removed in update snap

fix findPluginsInNodeModules

Merge branch 'master' into globby-10-update-with-fast-glob

package.json 71% changes removed in Merge branch 'next' ...

yarn.lock 41% changes removed in Merge branch 'next' ...

restore snap

fix `findPluginsInNodeModules`

src/common/load-plugins.js 50% changes removed in code style

return early

src/cli/util.js 50% changes removed in Restore logic

code style

sort

update snap

try mem

src/common/load-plugins.js 50% changes removed in mem loadPlugins fu...

mem loadPlugins function

fix

src/common/load-plugins.js 50% changes removed in remove mem

glob directories ins... ... remove mem

Squashed 3 commits:

glob directories instead of package.json

use deep

remove mem

src/common/load-plugins.js 60% changes removed in restore `findPlugins...

improve speed

support dot pattern

expand directories test

...__snapshots__/patterns.js.snap 64% changes removed in update test

restore import order

remove snap

update test

...__snapshots__/patterns.js.snap 53% changes removed in Merge branch 'next' ...

restore `findPluginsInNodeModules`

src/common/load-plugins.js 83% changes removed in Restore logic

Merge branch 'master' into globby-10-update-with-fast-glob

Merge branch 'next' into globby-10-update-with-fast-glob

...re-pipelines/jobs/dev-lint.yml 50% changes removed in Merge branch 'next' ...

...snapshots__/jsfmt.spec.js.snap 55% changes removed in Merge branch 'next' ...

...ar_interpolation/jsfmt.spec.js 50% changes removed in Merge branch 'next' ...

Update globby

fast-glob beta

Restore logic

src/cli/util.js 67% changes removed in Restore error info

Add tests for globby update

Merge branch 'add-glob-test' into globby-10-update-with-fast-glob

Fix tests

Remove option with default value

Try new beta version of fast-glob

Merge branch 'next' into globby-10-update-with-fast-glob

Restore error info

Add path.sep check

Powered by Pull Assistant. Last update bb042d8 ... b3bba07. Read the comment docs.

# Conflicts: # tests_integration/__tests__/__snapshots__/patterns.js.snap

# Conflicts: # package.json

Christopher J. Brody and others added 30 commits October 29, 2019 15:50

globby@10 update (with fast-glob implementation)

bb042d8

with some minor test snapshot updates in tests_integration since fast-glob does not always keep the same file order as node-glob

with no nodir: true option

f7297cb

use of no `nodir: true` option was introduced in 639c523 but it does not seem to be needed with some newer versions of globby

with workaround for fast-glob on Windows

5c898f8

ref: https://github.com/mrmlnc/fast-glob#how-to-write-patterns-on-windows Co-authored-by: fisker Cheung <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>

Revert "with no nodir: true option"

5997f1f

This reverts commit f7297cb.

revert updates to snapshots in tests_integration

8a94615

sort the file paths from globby

cefeb53

and update some snapshots in tests_integration

Update build scripts

e21e2aa

replace util.promisify with pify

bbbcfdd

style

01ddc44

typo

4869bbc

add pify to dict

21fad4b

check index.js

f78a602

debug

0b3b420

exclude transform-async-to-generator

e6b8e41

fix bin-prettier.js

5c2c5f1

restore disabled script

1cc3d9b

try depth:1

d12d1c0

remove depth add ./

cdd8788

sort dir

5b344e5

disable expandDirectories

df94b41

ref: https://github.com/sindresorhus/globby/blob/master/index.js#L95

use absolute path

211d61a

remove sort()

3b10b71

sort dir

493e96b

use alphasorti compare

99de6c8

remove './'

cc379b7

fix findPluginsInNodeModules

bd6ed7e

fix findPluginsInNodeModules

87fdca8

Merge branch 'master' into globby-10-update-with-fast-glob

28a8322

# Conflicts: # package.json # yarn.lock

restore snap

cb8aaed

fix findPluginsInNodeModules

257feb8

remove snap

07b9764

brody2consult mentioned this pull request Oct 31, 2019

[RFC DRAFT WIP] globby@10 update (with fast-glob implementation) prettier/prettier#6748

Closed

5 tasks

fisker added 2 commits November 1, 2019 09:58

update test

a1270a2

restore findPluginsInNodeModules

1703029

Merge branch 'master' into globby-10-update-with-fast-glob

c1cbe62

# Conflicts: # yarn.lock

fisker added 3 commits February 4, 2020 21:47

Merge branch 'next' into globby-10-update-with-fast-glob

d15e184

# Conflicts: # package.json # tests_integration/__tests__/__snapshots__/patterns.js.snap # tests_integration/__tests__/patterns.js # yarn.lock

Update globby

c16ac4a

fast-glob beta

e79d10c

fisker force-pushed the globby-10-update-with-fast-glob branch from 6d7bd5b to ee55e8d Compare February 4, 2020 14:18

Restore logic

4d349fc

fisker force-pushed the globby-10-update-with-fast-glob branch from ee55e8d to 4d349fc Compare February 4, 2020 15:11

fisker added 4 commits February 4, 2020 23:25

Add tests for globby update

e8e4fd9

Merge branch 'add-glob-test' into globby-10-update-with-fast-glob

3851c65

Fix tests

fcffe5a

Remove option with default value

7242e4f

fisker changed the base branch from master to next February 5, 2020 10:46

fisker added 4 commits February 10, 2020 07:14

Try new beta version of fast-glob

34183f1

Merge branch 'next' into globby-10-update-with-fast-glob

6fbe271

Merge branch 'next' into globby-10-update-with-fast-glob

755a2b2

# Conflicts: # tests_integration/__tests__/__snapshots__/patterns.js.snap

Merge branch 'next' into globby-10-update-with-fast-glob

ebb3531

# Conflicts: # package.json

fisker force-pushed the globby-10-update-with-fast-glob branch from aa5893b to becc585 Compare February 16, 2020 15:59

Restore error info

ea7ceb0

fisker force-pushed the globby-10-update-with-fast-glob branch from becc585 to ea7ceb0 Compare February 16, 2020 16:00

Add path.sep check

b3bba07

fisker closed this Mar 17, 2020

fisker deleted the globby-10-update-with-fast-glob branch March 17, 2020 02:53

github-actions Bot locked as resolved and limited conversation to collaborators Dec 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Globby 10 update with fast glob#120

feat: Globby 10 update with fast glob#120
fisker wants to merge 62 commits intonextfrom
globby-10-update-with-fast-glob

fisker commented Oct 31, 2019

Uh oh!

todo Bot commented Nov 1, 2019

Uh oh!

todo Bot commented Nov 1, 2019

Uh oh!

pull-assistant Bot commented Feb 4, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

fisker commented Oct 31, 2019

Uh oh!

todo Bot commented Nov 1, 2019

move `multiple-patterns` tests into this one

This comment was generated by todo based on a TODO comment in 1703029 in #120. cc @fisker.

Uh oh!

todo Bot commented Nov 1, 2019

move `multiple-patterns` tests into this one

This comment was generated by todo based on a TODO comment in c1cbe62 in #120. cc @fisker.

Uh oh!

pull-assistant Bot commented Feb 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

This comment was generated by todo based on a `TODO` comment in `1703029` in #120. cc @fisker.

This comment was generated by todo based on a `TODO` comment in `c1cbe62` in #120. cc @fisker.

pull-assistant Bot commented Feb 4, 2020 •

edited

Loading