This repository was archived by the owner on Mar 7, 2021. It is now read-only.
Add fsync support #276
Closed
Add fsync support #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey Adam, thanks for contributing! We're slowly migrating ourselves to a plan for contributing this code to the upstream kernel. Would you be interested in migrating your patch to be against https://github.com/Rust-for-Linux/linux/ ? |
Author
|
Yeah, no problem - by the way, is there a chat or something for the Rust-for-Linux group? I've got some questions that don't really make sense to submit as issues. For example, I'm not sure how to use the library as it is in https://github.com/Rust-for-Linux/linux/ for making a module that's not built-in. |
Member
|
Feel free to just file issues for the time being -- we're working on
setting up a mailing list.
…On Sat, Oct 17, 2020 at 10:20 AM Adam Bratschi-Kaye < ***@***.***> wrote:
Yeah, no problem - by the way, is there a chat or something for the
Rust-for-Linux group? I've got some questions that don't really make sense
to submit as issues.
For example, I'm not sure how to use the library as it is in
https://github.com/Rust-for-Linux/linux/ for making a module that's not
built-in.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#276 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBEJHOCGMGOMLTAGKA3SLGR4VANCNFSM4SUMJUBA>
.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I took a stab at adding
fsyncto the file operations. I'm not really sure what the return value is supposed to be used for, so maybe it should just be()?