Fix Vi mode cW deleting trailing whitespace - #12790
Closed
linsomniac wants to merge 1 commit into
Closed
Conversation
cW (change-WORD) changed through to the start of the next WORD, deleting the trailing whitespace. 02c0455 (Fix Vi mode cw deleting trailing whitespace, 2026-02-12) fixed this for cw but missed cW, and there is no reason for cw and cW to be inconsistent. Make cW change only to the end of the WORD, like cE and Vim, keeping the trailing whitespace. Fixes 38e633d (fish_vi_key_bindings: add support for count, 2025-12-16). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Member
#12630 is leaning towards rejecting AI-contributions, sorry. |
Contributor
Author
|
Reporting #12791 so this doesn't get lost. |
Contributor
|
thanks for cleaning up my diff |
|
Why was this LLM-generated PR merged? |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion in #12788
cW (change-WORD) changed through to the start of the next WORD, deleting the trailing whitespace. 02c0455 (Fix Vi mode cw deleting trailing whitespace, 2026-02-12) fixed this for cw but missed cW, and there is no reason for cw and cW to be inconsistent. Make cW change only to the end of the WORD, like cE and Vim, keeping the trailing whitespace.
Fixes 38e633d (fish_vi_key_bindings: add support for count, 2025-12-16).
TODOs:
Fixes issue #<issue-number>