You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry this has taken so long to review. I've updated it for the current codebase, and fixed the highlighting of the new arguments.
One thing I'm not sure about is the long option names. "Physical" is the term other shells use in the documentation, although I don't think it's a particularly good term - there's nothing physical about the file path! "Logical" matches realpath(1), but it means something different there. What about copying cp(1) with --dereference for -L and --no-dereference for -P?
zanchey
added a commit
to asukaminato0721/fish-shell
that referenced
this pull request
May 29, 2026
Sorry this has taken so long to review. I've updated it for the current codebase, and fixed the highlighting of the new arguments.
One thing I'm not sure about is the long option names. "Physical" is the term other shells use in the documentation, although I don't think it's a particularly good term - there's nothing physical about the file path! "Logical" matches realpath(1), but it means something different there. What about copying cp(1) with --dereference for -L and --no-dereference for -P?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Talk about your changes here.
Fixes issue #7206
TODOs: