Skip to content

Panic when suspending alias in pipeline #12301

Description

@lieuwex

When running the following ...

$ sh -c 'env HOME=$(mktemp -d) XDG_CONFIG_HOME= XDG_DATA_DIRS= /home/lieuwe/fish-shell/build/fish'
lieuwe@lieuwe-clevo /h/lieuwe> echo $version
4.3.3-snapshot-gef18b66
lieuwe@lieuwe-clevo /h/lieuwe> echo "alias less less" > ~/.config/fish/config.fish
lieuwe@lieuwe-clevo /h/lieuwe> source ~/.config/fish/config.fish
lieuwe@lieuwe-clevo /h/lieuwe> cat /dev/urandom | cat | less

... fish crashes when pressing CTRL-Z.

Weirdly enough, there is no problem with cat /dev/urandom | less.

stack trace
thread 'main' (1998372) panicked at src/proc.rs:219:13:
Process is not exited
stack backtrace:
   0:     0x5653950b58b2 - std[513e81d573b12216]::backtrace_rs::backtrace::libunwind::trace
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/../../backtrace/src/backtrace/libunwind.rs:117:9
   1:     0x5653950b58b2 - std[513e81d573b12216]::backtrace_rs::backtrace::trace_unsynchronized::
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/../../backtrace/src/backtrace/mod.rs:66:14
   2:     0x5653950b58b2 - std[513e81d573b12216]::sys::backtrace::_print_fmt
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/sys/backtrace.rs:74:9
   3:     0x5653950b58b2 - <::print::DisplayBacktrace as core[e243b1c403c90e51]::fmt::Display>::fmt
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/sys/backtrace.rs:44:26
   4:     0x565394e1bc5a - ::fmt
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/core/src/fmt/rt.rs:152:76
   5:     0x565394e1bc5a - core[e243b1c403c90e51]::fmt::write
   6:     0x5653950b4ab5 - std[513e81d573b12216]::io::default_write_fmt::
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/io/mod.rs:639:11
   7:     0x5653950b4ab5 - ::write_fmt
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/io/mod.rs:1994:13
   8:     0x5653950b4dbe - ::print
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/sys/backtrace.rs:47:9
   9:     0x5653950b4dbe - std[513e81d573b12216]::panicking::default_hook::{closure#0}
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/panicking.rs:292:27
  10:     0x5653950b4dbe - std[513e81d573b12216]::panicking::default_hook
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/panicking.rs:319:9
  11:     0x5653950a0b26 -  core[e243b1c403c90e51]::ops::function::Fn<(&'a std[513e81d573b12216]::panic::PanicHookInfo<'b>,), Output = ()> + core[e243b1c403c90e51]::marker::Sync + core[e243b1c403c90e51]::marker::Send> as core[e243b1c403c90e51]::ops::function::Fn<(&std[513e81d573b12216]::panic::PanicHookInfo,)>>::call
                               at /home/lieuwe/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/boxed.rs:2220:9
  12:     0x5653950a0b26 - fish[6f5e756fc4f60f8c]::panic::panic_handler::::{closure#0}
                               at /home/lieuwe/fish-shell/src/panic.rs:28:13
  13:     0x5653950b4789 -  core[e243b1c403c90e51]::ops::function::Fn<(&'a std[513e81d573b12216]::panic::PanicHookInfo<'b>,), Output = ()> + core[e243b1c403c90e51]::marker::Sync + core[e243b1c403c90e51]::marker::Send> as core[e243b1c403c90e51]::ops::function::Fn<(&std[513e81d573b12216]::panic::PanicHookInfo,)>>::call
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/alloc/src/boxed.rs:2220:9
  14:     0x5653950b4789 - std[513e81d573b12216]::panicking::panic_with_hook
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/panicking.rs:833:13
  15:     0x5653950ddc08 - std[513e81d573b12216]::panicking::panic_handler::{closure#0}
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/panicking.rs:691:13
  16:     0x5653950ddb89 - std[513e81d573b12216]::sys::backtrace::__rust_end_short_backtrace::
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/sys/backtrace.rs:182:18
  17:     0x5653950de18c - __rustc[84a8d1c3273c4f80]::rust_begin_unwind
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/std/src/panicking.rs:689:5
  18:     0x565394e1baeb - core[e243b1c403c90e51]::panicking::panic_fmt
                               at /rustc/fecb335cbad3d84ef3da39191ba094e6c726a5b4/library/core/src/panicking.rs:80:14
  19:     0x565394f4c1a8 - ::get_statuses
  20:     0x565394f5ca06 - fish[6f5e756fc4f60f8c]::exec::run_internal_process_or_short_circuit
                               at /home/lieuwe/fish-shell/src/exec.rs:668:39
  21:     0x565394f56872 - fish[6f5e756fc4f60f8c]::exec::exec_block_or_func_process
                               at /home/lieuwe/fish-shell/src/exec.rs:1114:5
  22:     0x565394f56872 - fish[6f5e756fc4f60f8c]::exec::exec_process_in_job
                               at /home/lieuwe/fish-shell/src/exec.rs:1346:62
  23:     0x565394f52745 - fish[6f5e756fc4f60f8c]::exec::exec_job
                               at /home/lieuwe/fish-shell/src/exec.rs:171:12
  24:     0x565394e9a050 - ::run_1_job
                               at /home/lieuwe/fish-shell/src/parse_execution.rs:1650:21
  25:     0x565394e98c9e - ::run_job_conjunction
                               at /home/lieuwe/fish-shell/src/parse_execution.rs:1729:31
  26:     0x565394e91bbe - ::run_job_list
                               at /home/lieuwe/fish-shell/src/parse_execution.rs:1765:27
  27:     0x565394e91bbe - ::eval_job_list
                               at /home/lieuwe/fish-shell/src/parse_execution.rs:219:14
  28:     0x565394e91bbe - ::eval_node
                               at /home/lieuwe/fish-shell/src/parse_execution.rs:158:46
  29:     0x565394ff7d38 - ::eval_node::
                               at /home/lieuwe/fish-shell/src/parser.rs:719:40
  30:     0x565394fff877 - ::eval_parsed_source
                               at /home/lieuwe/fish-shell/src/parser.rs:578:18
  31:     0x565395002666 - ::eval_with
                               at /home/lieuwe/fish-shell/src/parser.rs:537:25
  32:     0x565394edbb5c - ::eval
                               at /home/lieuwe/fish-shell/src/parser.rs:511:14
  33:     0x565394edbb5c - fish[6f5e756fc4f60f8c]::reader::reader::reader_run_command
                               at /home/lieuwe/fish-shell/src/reader/reader.rs:6025:27
  34:     0x565394edbb5c - fish[6f5e756fc4f60f8c]::reader::reader::read_i
                               at /home/lieuwe/fish-shell/src/reader/reader.rs:867:24
  35:     0x565394edbb5c - fish[6f5e756fc4f60f8c]::reader::reader::reader_read
                               at /home/lieuwe/fish-shell/src/reader/reader.rs:807:9
  36:     0x565394e15644 - fish[76f4ec30b4079d55]::throwing_main
                               at /home/lieuwe/fish-shell/src/bin/fish.rs:566:15
  37:     0x5653950a096c - >::call_once
                               at /home/lieuwe/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
  38:     0x5653950a096c - fish[6f5e756fc4f60f8c]::panic::panic_handler::
                               at /home/lieuwe/fish-shell/src/panic.rs:58:23
  39:     0x565394e19d20 - fish[76f4ec30b4079d55]::main
                               at /home/lieuwe/fish-shell/src/bin/fish.rs:367:9
  40:     0x5653950a1723 - >::call_once
                               at /home/lieuwe/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5
  41:     0x5653950a1723 - std[513e81d573b12216]::sys::backtrace::__rust_begin_short_backtrace::
                               at /home/lieuwe/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/backtrace.rs:166:18
  42:     0x565394e1a6b8 - main
  43:     0x7fc506c8a5b5 - __libc_start_call_main
  44:     0x7fc506c8a668 - __libc_start_main_alias_1
  45:     0x565394e0fa65 - _start
  46:                0x0 - 

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething that's not working as intended

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions