Skip to content

Fish 4.3.2 no longer installs prompts and themes #12241

Description

@asomers

With Fish version 4.3.2 , cmake no longer installs the prompts and themes. It did in 4.2.1 (I haven't tested other versions). I think that this is an accidental result of d8f1a2a . That change moved the location of prompts and themes in the source tree, but didn't adjust cmake/Install.cmake accordingly.

$ fish --version
fish, version 4.3.2
$ uname -a
FreeBSD 16_0-git 16.0-CURRENT FreeBSD 16.0-CURRENT amd64

Steps to Reproduce

Build fish via the FreeBSD ports system. The commands that ports executes to install the files are:

[  0% 1/2] /usr/local/bin/cmake -P /wrkdirs/usr/ports/shells/fish/work/.build/CMakeFiles/VerifyGlobs.cmake
[  0% 1/8] cd /wrkdirs/usr/ports/shells/fish/work/fish-4.3.2 && /usr/local/bin/cmake -E env FISH_CMAKE_BINARY_DIR=/wrkdirs/usr/ports/shells/fish/work/.build PREFIX=/usr/local DOCDIR=/usr/local/share/doc/fish DATADIR=/usr/local/share SYSCONFDIR=/usr/local/etc BINDIR=/usr/local/bin CARGO_TARGET_DIR=/wrkdirs/usr/ports/shells/fish/work/.build/cargo/build CARGO_BUILD_RUSTC=/usr/local/bin/rustc FISH_SPHINX=/usr/local/bin/sphinx-build /usr/local/bin/cargo build --bin fish --release  --target x86_64-unknown-freebsd --no-default-features --features=localize-messages && /usr/local/bin/cmake -E copy /wrkdirs/usr/ports/shells/fish/work/.build/cargo/build/x86_64-unknown-freebsd/release/fish /wrkdirs/usr/ports/shells/fish/work/.build
    Finished `release` profile [optimized] target(s) in 0.06s
[ 12% 2/8] cd /wrkdirs/usr/ports/shells/fish/work/fish-4.3.2 && /wrkdirs/usr/ports/shells/fish/work/fish-4.3.2/build_tools/git_version_gen.sh /wrkdirs/usr/ports/shells/fish/work/.build
[ 37% 5/8] cd /wrkdirs/usr/ports/shells/fish/work/.build && ln -f fish fish_indent
[ 50% 6/8] cd /wrkdirs/usr/ports/shells/fish/work/.build && ln -f fish fish_key_reader
[ 62% 6/8] cd /wrkdirs/usr/ports/shells/fish/work/.build && mkdir -p /wrkdirs/usr/ports/shells/fish/work/.build/user_doc/html/_static/ && env FISH_BUILD_VERSION_FILE=/wrkdirs/usr/ports/shells/fish/work/.build/FISH-BUILD-VERSION-FILE PATH="/wrkdirs/usr/ports/shells/fish/work/.build:$PATH" /usr/local/bin/sphinx-build -j auto -q -b html -c /wrkdirs/usr/ports/shells/fish/work/fish-4.3.2/doc_src -d /wrkdirs/usr/ports/shells/fish/work/.build/user_doc/.doctrees-html /wrkdirs/usr/ports/shells/fish/work/fish-4.3.2/doc_src /wrkdirs/usr/ports/shells/fish/work/.build/user_doc/html
[ 75% 6/8] cd /wrkdirs/usr/ports/shells/fish/work/.build && env FISH_BUILD_VERSION_FILE=/wrkdirs/usr/ports/shells/fish/work/.build/FISH-BUILD-VERSION-FILE /usr/local/bin/sphinx-build -j auto -q -b man -c /wrkdirs/usr/ports/shells/fish/work/fish-4.3.2/doc_src -d /wrkdirs/usr/ports/shells/fish/work/.build/user_doc/.doctrees-man /wrkdirs/usr/ports/shells/fish/work/fish-4.3.2/doc_src /wrkdirs/usr/ports/shells/fish/work/.build/user_doc/man/man1
[ 75% 7/8] cd /wrkdirs/usr/ports/shells/fish/work/.build && /usr/local/bin/cmake -DCMAKE_INSTALL_DO_STRIP=1 -P cmake_install.cmake

Metadata

Metadata

Assignees

No one assigned

    Labels

    cmakeregressionSomething that used to work, but was broken, especially between releases

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions