Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Nov 12, 2024 #5202

Merged
merged 38 commits into from
Nov 12, 2024
Merged

Deploy Nov 12, 2024 #5202

merged 38 commits into from
Nov 12, 2024

Conversation

canova
Copy link
Member

@canova canova commented Nov 12, 2024

[Nazım Can Altınova] Change the test-build-coverage script to use 'yarn test' instead of jest directly (#5180)
[Nazım Can Altınova] Retrieve the page favicons from the browser and display it on the tab selector (#5166)
[Nazım Can Altınova] Add default favicons to extensions and pages that don't have nay favicons (#5182)
[Nazım Can Altınova] Do not clip the favicons in call tree (#5185)
[Nazım Can Altınova] Compute the profiling start and end time for chrome tracing profiles (#5187)
[Nazım Can Altınova] Do not include the profile startTime in window title if it's zero (#5188)
[Markus Stange] Profile format changes for flows and stack-based markers (#5186)
[Nazım Can Altınova] Fix some svg images for Chrome by replacing context-fill with the black color (#5201)
[Nazım Can Altınova] Enable the tab selector (#5197)
[Nazım Can Altınova] Do not make the parent process visible by default when something is selected in the tab selector (#5198)

canova and others added 30 commits October 29, 2024 11:53
…est directly (#5180)

Since it was using the jest directly without setting the important
environment variables, `test-build-coverage` script was failing. If you
were to run `test-coverage`, because the first one was failing, it was
always stopping early without serving the files.
In the following commit, we are going to be using the sha1 code that we
have that relies on window.crypto. We have to add it to jest as well to
make sure that we don't break the tests.
Firefox bumped its version while working on this patch!
… selector (#5166)

This requires changes from [Bug
1921778](https://bugzilla.mozilla.org/show_bug.cgi?id=1921778) since it
adds the webchannel changes in the backend.

This PR adds the ability to retrieve the favicons for pages as a data
url, so we can display them easily in the frontend without needing to
fetch them from their url every time we open a profile.

This also changes how we use the `Icon` component and how we compute the
css class names for them. Let me know what you think!

Note that this doesn't change the other icons that we have in places
like call tree. I would prefer to do it as a followup as there are some
questions to answer there.
…cons (#5182)

This PR adds default icons for extensions and pages. So if we don't have
any favicons for these, these default ones will be used in the tab
selector.
I'm not a fan of this solution, but I'm also not a fan of our current
way of handling this column. The icon itself is 14px but the parent
div's width is 10px. So I would prefer to change the parent's width
to 14px too, but this parent itself is not really responsible of
paddings arond this. It's the adjacent separator divs who are
responsible. So this other solution will be a lot more difficult.
canova and others added 8 commits November 5, 2024 20:16
…5188)

Previously we were always including the profile `startTime` in the title
even when it was zero. It was resulting in a title that includes
`1/1/1970, 12:00:00 AM UTC`, which is not useful for anyone. This was
more visible in the Chrome profiles especially since they don't have a
metadata.

This patch changes this title algorithm to make sure that we don't print
the profile time when the profile `startTime` is zero. It also makes
sure that `(public)` annotation is properly added as well as all the
separators.
This changeset changes the type definition for marker schema
field types and for the marker schema itself, to include the new
field types 'flow-id' and 'terminating-flow-id'. It also has some
minimal changes to treat the new field types as if they were unique-string
fields.
Somewhat unrelated to flows, it also adds an optional `isStackBased`
field to the marker schema type, which is currently unused. This is
for #3141 .

Additionally, it increments the version of the two profile formats,
so that profiles with the new field types won't be loaded by
older front-ends.
This PR changes the type definition for marker schema field types and
for the marker schema itself, to include the new field types 'flow-id'
and 'terminating-flow-id'. It also has some minimal changes to treat the
new field types as if they were unique-string fields.
Somewhat unrelated to flows, it also adds an optional `isStackBased`
field to the marker schema type, which is currently unused. This is for
#3141 .

Additionally, it increments the version of the two profile formats, so
that profiles with the new field types won't be loaded by older
front-ends.
@canova canova merged commit 07188f2 into production Nov 12, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants