Add ability to launch containers with vm local rootfs. #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
reviewed
Feb 23, 2022
agent/service.go
Outdated
| return nil | ||
| }) | ||
|
|
||
| isVmLocalRootFs := vm.IsLocalMount(req.Rootfs[0]) |
There was a problem hiding this comment.
Do we need to do something for Rootfs[1]?
Contributor
Author
There was a problem hiding this comment.
Right now, runtime/service.go enforces exactly one rootfs per container.
agent/service.go
Outdated
| Source: req.Rootfs[0].Source, | ||
| Options: req.Rootfs[0].Options, | ||
| } | ||
| specData, err = vm.UpdateSpec(requestCtx, specData, rootfsMount) |
There was a problem hiding this comment.
Could this be more specific? The function is updating the spec, but how?
internal/vm/mount_test.go
Outdated
Comment on lines
26
to
28
| Type: "mount", | ||
| Source: "mount", | ||
| Target: "mount", |
There was a problem hiding this comment.
Let's have something more realistic rather than "mount" :)
Kern--
force-pushed
the
vm-mounts
branch
2 times, most recently
from
d321519 to
8ab58ac
Compare
With this change, if a mount is returned from a snapshotter where the type is prefixed with "vm:", then firecracker-containerd will not assume it is a block device and will pass the mount information directly to the agent in the VM to handle mounting the container's rootfs. Signed-off-by: Kern Walster <[email protected]>
kzys
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, if a mount is returned from a snapshotter
where the type is prefixed with "vm:", then firecracker-containerd
will not assume it is a block device and will pass the mount
information directly to the agent in the VM to handle mounting
the container's rootfs.
Signed-off-by: Kern Walster [email protected]
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.