Skip to content

Conversation

@russellwheatley
Copy link
Member

Description

See title.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

CONTRIBUTING.md Outdated
10)Update the documentation by manually triggering the [publish docs workflow](https://github.com/FirebaseExtended/flutterfire/actions/workflows/docs.yaml); ![image](https://user-images.githubusercontent.com/5347038/117001552-69095780-acda-11eb-934c-a228be6f5c7a.png)

7) After successful dry run, commit all changes with the signature "chore(release): prepare for release".
8) Run `git push origin master` & open pull request for review on GitHub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be git push origin master here - we're pushing the new release/* branch instead

@Salakar Salakar merged commit 9cef906 into master May 3, 2022
@Salakar Salakar deleted the @russell/update-release-docs branch May 3, 2022 11:29
@firebase firebase locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants