Skip to content

Conversation

@samtstern
Copy link
Contributor

Description

I just copied the one from flutter/plugins and changed the content key to point at README.md*

Related Issues

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • [ x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [x ] All existing and new tests are passing.
  • [x ] I updated/added relevant documentation (doc comments with ///).
  • [ x] The analyzer (flutter analyze) does not report any problems on my PR.
  • [ x] I read and followed the Flutter Style Guide.
  • [ x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [ x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [ x] I updated CHANGELOG.md to add a description of the change.
  • [ x] I signed the CLA.
  • [ x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [ x] No, this is not a breaking change.

I just copied the one from flutter/plugins and changed the `content` key to point at README.md
@samtstern samtstern requested a review from kroikie September 10, 2019 16:24
Copy link
Collaborator

@kroikie kroikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam!

@kroikie kroikie merged commit 2f063cf into master Sep 10, 2019
@samtstern
Copy link
Contributor Author

Follow ups that this enabled:
firebase/firebaseopensource.com@368a84c
firebase/firebaseopensource.com@99e6208

@kroikie kroikie deleted the samstern-fir-oss branch September 10, 2019 16:39
@collinjackson
Copy link
Contributor

Seems like the old plugins repository description is still on firebaseopensource.com:

Screen Shot 2019-09-10 at 09 42 29

@kroikie
Copy link
Collaborator

kroikie commented Sep 10, 2019

@samtstern Where is that text generated?

@samtstern
Copy link
Contributor Author

I am redeploying the site now to fix that.

@samtstern
Copy link
Contributor Author

Also see:
flutter/plugins#2055

@samtstern
Copy link
Contributor Author

New page is now live:
https://firebaseopensource.com/projects/firebaseextended/flutterfire/

Old page is still live but blacklisted from appearing on the homepage.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants