feat(web): remove the dependency on package:js in favor of dart:js_interop
#12534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarekkMA
suggested changes
Mar 26, 2024
13 tasks
russellwheatley
previously requested changes
Mar 28, 2024
packages/firebase_database/firebase_database/example/lib/main.dart
Outdated
Show resolved
Hide resolved
exaby73
approved these changes
Mar 28, 2024
TarekkMA
reviewed
Mar 29, 2024
| firebase_auth.main(); | ||
| firebase_database.main(); | ||
| firebase_crashlytics.main(); | ||
| firebase_auth.main(); |
Contributor
There was a problem hiding this comment.
any reason for the change?
Contributor
Author
There was a problem hiding this comment.
We have add a race condition with auth for a bit of time now, and I tried this out of curiosity and seems to work better ... Might be just placebo tho 😅
TarekkMA
approved these changes
Mar 29, 2024
Collaborator
|
Can we get this merged? |
russellwheatley
approved these changes
Apr 2, 2024
Contributor
Author
|
@kevmoo Merged, will be part of next release that should be out today :) |
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…_interop` (firebase#12534) * feat(web): remove the dependency on package:js in favor of dart:js_interop * fix typing * fixing more stuffs * tests? * tests * more * fix typing * fix * fix typing * fixing interop typing * fixing null safety * more fix * database * tests * tests? * fix typing * test order? * storage * tests messaging * fix firestore boxing * test * improve * test * final?? * clean example app
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…_interop` (firebase#12534) * feat(web): remove the dependency on package:js in favor of dart:js_interop * fix typing * fixing more stuffs * tests? * tests * more * fix typing * fix * fix typing * fixing interop typing * fixing null safety * more fix * database * tests * tests? * fix typing * test order? * storage * tests messaging * fix firestore boxing * test * improve * test * final?? * clean example app
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…_interop` (firebase#12534) * feat(web): remove the dependency on package:js in favor of dart:js_interop * fix typing * fixing more stuffs * tests? * tests * more * fix typing * fix * fix typing * fixing interop typing * fixing null safety * more fix * database * tests * tests? * fix typing * test order? * storage * tests messaging * fix firestore boxing * test * improve * test * final?? * clean example app
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…_interop` (firebase#12534) * feat(web): remove the dependency on package:js in favor of dart:js_interop * fix typing * fixing more stuffs * tests? * tests * more * fix typing * fix * fix typing * fixing interop typing * fixing null safety * more fix * database * tests * tests? * fix typing * test order? * storage * tests messaging * fix firestore boxing * test * improve * test * final?? * clean example app
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 16, 2024
…_interop` (firebase#12534) * feat(web): remove the dependency on package:js in favor of dart:js_interop * fix typing * fixing more stuffs * tests? * tests * more * fix typing * fix * fix typing * fixing interop typing * fixing null safety * more fix * database * tests * tests? * fix typing * test order? * storage * tests messaging * fix firestore boxing * test * improve * test * final?? * clean example app
guide-loclt
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 16, 2024
…_interop` (firebase#12534) * feat(web): remove the dependency on package:js in favor of dart:js_interop * fix typing * fixing more stuffs * tests? * tests * more * fix typing * fix * fix typing * fixing interop typing * fixing null safety * more fix * database * tests * tests? * fix typing * test order? * storage * tests messaging * fix firestore boxing * test * improve * test * final?? * clean example app
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also removing the
webpackage when it wasn't usedRemoved tests that were generating mocks since those are not compatible with the new interop and were passthrough tests.
Related Issues
#12466
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?