Merged
Conversation
Yuangwang
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add --port to
ng servecustom commands because angular does not support nodejs.process.env.PORT. Without --port the ng CLI will use its own default port and the emulator will eventually time out when it finds nothing on the expected port.As a result we are also throwing an error if any custom command has specified
--portor-pas this will result in the same issue above.A caveat is that if it's not a custom start command and the emulator executes
npm run dev, thedevscript may have--portbut we won't be able to detect this. This will result in the same error above.Scenarios Tested
custom start command is
ng servethe default
npm run devcommand is used for a nextjs app