Skip to content

ci: Updated named db tests to run against enterprise db#9770

Merged
MarkDuckworth merged 8 commits intomainfrom
markduckworth/run-ent-tests
Mar 27, 2026
Merged

ci: Updated named db tests to run against enterprise db#9770
MarkDuckworth merged 8 commits intomainfrom
markduckworth/run-ent-tests

Conversation

@MarkDuckworth
Copy link
Copy Markdown
Contributor

@MarkDuckworth MarkDuckworth commented Mar 26, 2026 •
edited
Loading

No changeset, CI only.

Skipping tests to get tests running ASAP.

@MarkDuckworth MarkDuckworth requested review from a team as code owners March 26, 2026 16:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 26, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6106a4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Firestore test configurations to use an 'enterprise' database ID and adds a new --firestoreEdition flag to the test runner. The runner now sets the RUN_ENTERPRISE_TESTS environment variable when the enterprise edition is specified. Feedback was provided to improve code clarity and formatting by adding curly braces and fixing indentation in the test runner's conditional logic.

Comment thread packages/firestore/scripts/run-tests.ts Outdated
@MarkDuckworth MarkDuckworth merged commit 3ddfe88 into main Mar 27, 2026
44 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/run-ent-tests branch March 27, 2026 15:19
@firebase firebase locked and limited conversation to collaborators Apr 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@wu-hui wu-hui wu-hui approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wu-hui wu-hui

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarkDuckworth @DellaBitta @wu-hui