fix(firestore): read user data in internal pipeline proto serialization#9752
fix(firestore): read user data in internal pipeline proto serialization#9752
Conversation
Adds a step to `internalPipelineToExecutePipelineRequestProto` to read user data before serialization. This function was broken in #9715, and caused the `console support` tests to fail, which use this method to verify pipelines get serialized as expected. These test failures weren't caught since they weren't run in CI, and were skipped when ran locally with `test:lite` and `test:browser`. I verified these tests now pass using `test:node:prod`.
🦋 Changeset detectedLatest commit: 327f699 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical internal serialization bug within the Firestore SDK that prevented proper conversion of pipeline data to its protocol buffer representation. By ensuring user data is correctly read before serialization, it restores the functionality of internal testing pipelines and prevents future regressions in this area, specifically fixing previously failing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces user data reading capabilities into the internal pipeline serialization process. It imports newUserDataReader and UserDataSource, then initializes a UserDataReader and a context within the _internalPipelineToExecutePipelineRequestProto function to call pipeline._readUserData. There are no review comments to provide feedback on.
3 participants
Adds a step to
internalPipelineToExecutePipelineRequestPrototo read user data before serialization. Fixes an inThis function was broken in #9715, and caused the
console supporttests to fail, which use this method to verify pipelines get serialized as expected.These test failures weren't caught since they weren't run in CI, and were skipped when ran locally with
test:liteandtest:browser. I verified these tests now pass usingtest:node:prod.This is an internal change, so I did not add a changelog entry.