Update the version of firebase to use for Data Connect E2E test#9737
Update the version of firebase to use for Data Connect E2E test#9737
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase dependency to the latest version, which resolves issues with new generated SDKs. The yarn.lock file has been updated accordingly to reflect the new dependency versions and their integrity hashes. One area for improvement is to specify a version range for the firebase dependency in package.json instead of using "latest" to ensure more predictable and stable builds.
| }, | ||
| "dependencies": { | ||
| "firebase": "11.8.1" | ||
| "firebase": "latest" |
There was a problem hiding this comment.
Using "latest" for a dependency can lead to unpredictable builds and potential breaking changes when new major versions are released. It's generally recommended to specify a semantic versioning range (e.g., ^12.11.0 or ~12.11.0) to allow for compatible updates while maintaining stability and reproducibility across environments.
| "firebase": "latest" | |
| "firebase": "^12.11.0" |
There was a problem hiding this comment.
This is used for a test app that is used to verify builds and integration tests against the latest sdk version => so this is fine.
DellaBitta
changed the title
3 participants
e2e/data-connect is used by Kokoro tests for the generated SDK. There are new generated SDKs that depend on the newer version of firebase data connect, therefore they are failing. This PR should fix that.