feat(data-connect): refactor streaming tests and ensure synchronicity of invokeQuery/invokeMutation#9723
Conversation
🦋 Changeset detectedLatest commit: 1ca6d55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the existing streaming tests to enhance their structure, readability, and maintainability. The primary goal is to prepare the test suite for future feature additions by improving its organization and clarity, without altering any existing application behavior. This includes minor adjustments to variable names, test ordering, and the nesting of test descriptions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the streaming transport tests by improving test structure, adding cleanup hooks, and enhancing assertions. While these are positive changes, there's a critical issue where the sendMessage method signature in the test transport implementation was changed to be async, making it incompatible with the synchronous signature in the abstract base class. This will cause a compilation failure and needs to be addressed by either reverting the change or updating the base class and all its call sites to be asynchronous.
stephenarosaj
requested review from
a team,
aashishpatil-g and
maneesht
as code owners
stephenarosaj
changed the title
… promise rejection checking
stephenarosaj
changed the title
2 participants
Refactor streaming tests before adding further functionality. Also called out the assumption that
invokeQueryandinvokeMutationmust make tracking state changes synchronously and re-ordered operations within these methods to lower the chances of future changes introducing asynchronous functionality which prevents tracking from happening before a promise is returned to the caller.