Revert "Merge branch 'crashlytics-tracing' into crashlytics"#9705
Revert "Merge branch 'crashlytics-tracing' into crashlytics"#9705MaesterChestnut merged 1 commit intocrashlyticsfrom
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous merge that introduced tracing capabilities to the Crashlytics SDK. The primary goal is to remove the OpenTelemetry tracing integration, including its associated configurations, dependencies, and API surface, effectively rolling back the tracing functionality from the codebase. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts the 'crashlytics-tracing' feature. While no security vulnerabilities were identified as no specific changes were provided for review, a critical issue that will likely break compilation has been found. Additionally, there are medium-severity issues concerning corrupted documentation and a reduction in type safety.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/crashlytics/src/logging/logger-provider.ts (125-134)
The shutdown() and forceFlush() methods are being removed from OTLPLogExporter. However, the base class OTLPExporterBase (in version 0.205.0, which this PR reverts to) is an abstract class that requires these methods to be implemented. Removing them will cause a compilation error. These methods should not be removed.
docs-devsite/crashlytics_react-router.md (18)
The description for CrashlyticsRoutes in the table is corrupted. The text "<code>Routes</code> from react-router-dom`" has been removed, leaving a blank space. This appears to be an error from the revert process.
| [CrashlyticsRoutes({ firebaseApp, crashlyticsOptions, children, ...props })](./crashlytics_react-router.md#crashlyticsroutes_707e4a5) | A wrapper around <code>Routes</code> from <code>react-router-dom</code> that automatically captures errors in route components.<!-- -->This component acts as a replacement for <code>Routes</code> from <code>react-router-dom</code>. It wraps the routes in an error boundary that captures errors thrown during rendering and reports them to Crashlytics. The error boundary is reset on navigation (path changes). |
docs-devsite/crashlytics_react-router.md (31)
The description for CrashlyticsRoutes is corrupted here as well. The text "Routes from react-router-dom" has been removed, leaving a blank space.
A wrapper around `Routes` from `react-router-dom` that automatically captures errors in route components.
packages/crashlytics/src/auto-constants.ts (23-24)
The type of AUTO_CONSTANTS is being changed from Record<string, string> to any. Using any weakens type safety and should be avoided. If there's a type error causing this change, it's better to understand the root cause and fix it properly rather than resorting to any. Please restore the original, more specific type.
export const AUTO_CONSTANTS: Record<string, string> = {};
This reverts commit 0045da8.
This reverts commit 0045da8.
2 participants
This reverts commit b2c174c, reversing changes made to 861ce74.