Conversation
🦋 Changeset detectedLatest commit: 7b109ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on removing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Changeset File Check
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully removes the updateEmulatorBanner() function and all its associated calls and helper utilities across the codebase. The changes are consistent with the stated objective of removing the banner due to security concerns related to innerHTML usage. The removal is clean and does not introduce any new issues.
| '@firebase/database': patch | ||
| '@firebase/storage': patch | ||
| '@firebase/auth': patch | ||
| '@firebase/util': minor |
There was a problem hiding this comment.
FYI I am not bumping firebase to minor because I don't think a minor bump to util (non-public-facing) justifies a minor bump to firebase. Util's public API is changing, but that API is only consumed by other packages so it's not really public at the firebase package level.
This is fine - see other comment. |
hsubox76
requested review from
a team,
NhienLam,
Xiaoshouzi-gh,
aashishpatil-g,
lisajian,
maneesht,
mansisampat,
pashanka,
sam-gc and
tonyjhuang
as code owners
4 participants
Revert #8977 and #9055 - changes made to add an emulator warning banner for Firebase Studio. This banner uses innerHTML and is blocked on security checks from being imported into google3. The changes made to enable emulator + SDK functionality in Firebase Studio are still in the codebase, only the warning banner code is being removed.