VinF Hybrid Inference: throw if only_on_device and model is unavailable#8965
Merged
erikeldridge merged 3 commits intovaihi-expfrom Apr 23, 2025
Merged
VinF Hybrid Inference: throw if only_on_device and model is unavailable#8965erikeldridge merged 3 commits intovaihi-expfrom
erikeldridge merged 3 commits intovaihi-expfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: we're currently falling back to Cloud even if the mode is only_on_device.
Proposal:
Also: remove stale tests for systemInstruction; I added a backlog item for figuring out if we want to honor systemInstruction passed in the request vs onDeviceParams.