VinF Hybrid Inference #1: Update the API#8874
Closed
erikeldridge wants to merge 17 commits intovertexai-hybridinference-integrationfrom
Closed
VinF Hybrid Inference #1: Update the API#8874erikeldridge wants to merge 17 commits intovertexai-hybridinference-integrationfrom
erikeldridge wants to merge 17 commits intovertexai-hybridinference-integrationfrom
Conversation
|
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
Contributor
Vertex AI Mock Responses Check
|
hsubox76
reviewed
Apr 9, 2025
| "lib": [ | ||
| "ESNext" | ||
| "ESNext", | ||
| "dom" |
Contributor
Author
There was a problem hiding this comment.
Without this, adding the @types/dom-chromium-ai dependency causes the postsubmit script to fail. I'll try reproing the issue on a stand-alone branch.
This was referenced Apr 9, 2025
dlarocque
requested changes
Apr 15, 2025
| } | ||
|
|
||
| /** | ||
| * Toggles hybrid inference. |
Contributor
There was a problem hiding this comment.
Could you add the @public tag here and in other JSDoc comments for public APIs?
| /** | ||
| * Defines the name of the default in-cloud model to use for hybrid inference. | ||
| */ | ||
| static DEFAULT_HYBRID_IN_CLOUD_MODEL = 'gemini-2.0-flash-lite'; |
Contributor
There was a problem hiding this comment.
Could we avoid defining a default model? If this model string is deprecated in the future, and a user is using an old version of the SDK, would using this default result in an error?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the getGenerativeModel getter to accept
ModelParamsorHybridParams. TheHybridParams.modefield indicates whether hybrid inference is intended.This change just updates the inputs. All existing tests pass, so the diff should be relatively easy to understand. The next change will use the inputs.