DO NOT MERGE Copy #7963 code changes to run github actions as a contributor by dconeybe · Pull Request #7965 · firebase/firebase-js-sdk

dconeybe · 2024-01-19T20:12:08Z

Copy code changes from #7963 so the github actions can be run by a contributor

DO NOT MERGE!

…ntributor

changeset-bot · 2024-01-19T20:12:11Z

⚠️ No Changeset found

Latest commit: 8c7a241

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-01-19T20:14:04Z

Changeset File Check ⚠️

Changeset formatting error in following file:%0A %0A Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.%0A If this change doesn't need a release, run `changeset add --empty`.%0A %0A

google-oss-bot · 2024-01-19T20:32:42Z

Size Report ¹

Affected Products

@firebase/util
Type Base (4b5a82e) Merge (f599c70) Diff
browser 23.1 kB 23.1 kB +23 B (+0.1%)
esm5 24.7 kB 24.7 kB +23 B (+0.1%)
main 30.4 kB 30.5 kB +23 B (+0.1%)
module 23.1 kB 23.1 kB +23 B (+0.1%)

`bundle`

Type	Base (`4b5a82e`)	Merge (f599c70)	Diff
firestore (CSI Auto Indexing Disable and Delete)	268 kB	268 kB	+23 B (+0.0%)
firestore (CSI Auto Indexing Enable)	268 kB	268 kB	+23 B (+0.0%)
firestore (Persistence)	303 kB	303 kB	+23 B (+0.0%)
firestore (Query Cursors)	246 kB	246 kB	+23 B (+0.0%)
firestore (Query)	243 kB	243 kB	+23 B (+0.0%)
firestore (Read data once)	231 kB	231 kB	+23 B (+0.0%)
firestore (Read Write w Persistence)	321 kB	321 kB	+23 B (+0.0%)
firestore (Realtime updates)	234 kB	234 kB	+23 B (+0.0%)
firestore (Transaction)	211 kB	211 kB	+23 B (+0.0%)
firestore (Write data)	211 kB	211 kB	+23 B (+0.0%)

firebase
Type Base (4b5a82e) Merge (f599c70) Diff
firebase-compat.js 779 kB 779 kB +21 B (+0.0%)
firebase-firestore-compat.js 341 kB 341 kB +21 B (+0.0%)
firebase-firestore.js 434 kB 434 kB +23 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/8abdW7R2rA.html

google-oss-bot · 2024-01-19T20:45:34Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- addDoc
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 202 kB 202 kB +23 B (+0.0%)
- deleteAllPersistentCacheIndexes
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 165 kB 165 kB +23 B (+0.0%)
- deleteDoc
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 193 kB 193 kB +23 B (+0.0%)
- disableNetwork
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 181 kB 181 kB +23 B (+0.0%)
- disablePersistentCacheIndexAutoCreation
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 165 kB 165 kB +23 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 258 kB 258 kB +23 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 294 kB 294 kB +23 B (+0.0%)
- enableNetwork
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 181 kB 181 kB +23 B (+0.0%)
- enablePersistentCacheIndexAutoCreation
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 165 kB 165 kB +23 B (+0.0%)
- executeWrite
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 192 kB 192 kB +23 B (+0.0%)
- getAggregateFromServer
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 188 kB 188 kB +23 B (+0.0%)
- getCountFromServer
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 189 kB 189 kB +23 B (+0.0%)
- getDoc
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 222 kB 222 kB +23 B (+0.0%)
- getDocFromCache
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 173 kB 173 kB +23 B (+0.0%)
- getDocFromServer
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 222 kB 222 kB +23 B (+0.0%)
- getDocs
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 224 kB 224 kB +23 B (+0.0%)
- getDocsFromCache
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 181 kB 181 kB +23 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 223 kB 223 kB +23 B (+0.0%)
- loadBundle
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 191 kB 191 kB +23 B (+0.0%)
- memoryEagerGarbageCollector
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 163 kB 163 kB +23 B (+0.0%)
- memoryLocalCache
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 178 kB 178 kB +23 B (+0.0%)
- memoryLruGarbageCollector
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 170 kB 170 kB +23 B (+0.0%)
- namedQuery
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 166 kB 166 kB +23 B (+0.0%)
- onSnapshot
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 224 kB 224 kB +23 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 214 kB 214 kB +23 B (+0.0%)
- persistentLocalCache
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 255 kB 255 kB +23 B (+0.0%)
- persistentMultipleTabManager
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 291 kB 291 kB +23 B (+0.0%)
- persistentSingleTabManager
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 255 kB 255 kB +23 B (+0.0%)
- runTransaction
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 202 kB 202 kB +23 B (+0.0%)
- setDoc
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 201 kB 201 kB +23 B (+0.0%)
- setIndexConfiguration
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 169 kB 169 kB +23 B (+0.0%)
- updateDoc
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 202 kB 202 kB +23 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 182 kB 182 kB +23 B (+0.0%)
- writeBatch
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size-with-ext-deps 204 kB 204 kB +23 B (+0.0%)
@firebase/util
- isSafari
  Size
  Type Base (4b5a82e) Merge (f599c70) Diff
  size 4.27 kB 4.30 kB +23 B (+0.5%)
  size-with-ext-deps 4.27 kB 4.30 kB +23 B (+0.5%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/z9MG1xEtMR.html

dconeybe · 2024-01-19T22:01:26Z

Done with this.

copy code changes from #7963 so the github actions can be run by a co…

e8b15c0

…ntributor

dconeybe added the do-not-merge label Jan 19, 2024

dconeybe self-assigned this Jan 19, 2024

dconeybe mentioned this pull request Jan 19, 2024

Fix isSafari() throwing on React Native (fixes #7962) #7963

Merged

use !! to coerce navigator.userAgent to a boolean

8c7a241

dconeybe closed this Jan 19, 2024

dconeybe deleted the dconeybe/IsSafariReactNativeFix branch January 19, 2024 22:01

firebase locked and limited conversation to collaborators Feb 19, 2024

Conversation

dconeybe commented Jan 19, 2024

Uh oh!

changeset-bot Bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Jan 19, 2024

Changeset File Check ⚠️

Uh oh!

google-oss-bot commented Jan 19, 2024

Size Report 1

Affected Products

@firebase/util

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jan 19, 2024

Size Analysis Report 1

Affected Products

@firebase/firestore

addDoc

deleteAllPersistentCacheIndexes

deleteDoc

disableNetwork

disablePersistentCacheIndexAutoCreation

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

enablePersistentCacheIndexAutoCreation

executeWrite

getAggregateFromServer

getCountFromServer

getDoc

getDocFromCache

getDocFromServer

getDocs

getDocsFromCache

getDocsFromServer

loadBundle

memoryEagerGarbageCollector

memoryLocalCache

memoryLruGarbageCollector

namedQuery

onSnapshot

onSnapshotsInSync

persistentLocalCache

persistentMultipleTabManager

persistentSingleTabManager

runTransaction

setDoc

setIndexConfiguration

updateDoc

waitForPendingWrites

writeBatch

@firebase/util

isSafari

Test Logs

Uh oh!

dconeybe commented Jan 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Jan 19, 2024 •

edited

Loading

Size Report ¹

`@firebase/util`

`bundle`

`firebase`

Size Analysis Report ¹

`@firebase/firestore`

`addDoc`

`deleteAllPersistentCacheIndexes`

`deleteDoc`

`disableNetwork`

`disablePersistentCacheIndexAutoCreation`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`enablePersistentCacheIndexAutoCreation`

`executeWrite`

`getAggregateFromServer`

`getCountFromServer`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`loadBundle`

`memoryEagerGarbageCollector`

`memoryLocalCache`

`memoryLruGarbageCollector`

`namedQuery`

`onSnapshot`

`onSnapshotsInSync`

`persistentLocalCache`

`persistentMultipleTabManager`

`persistentSingleTabManager`

`runTransaction`

`setDoc`

`setIndexConfiguration`

`updateDoc`

`waitForPendingWrites`

`writeBatch`

`@firebase/util`

`isSafari`