Firestore: Small Count API documentation improvements#7933
Merged
Conversation
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (d7ace80) and merge commit (3bbcaf8).Test Logs |
This was referenced Jan 9, 2024
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (d7ace80) and merge commit (3bbcaf8).Test Logs |
egilmorez
approved these changes
Jan 10, 2024
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Text edits LGTM, thanks!
This was referenced Jan 10, 2024
This was referenced Jan 10, 2024
dconeybe
requested review from
a team,
Xiaoshouzi-gh,
kevinthecheung,
lisajian,
markarndt,
renkelvin and
sam-gc
as code owners
tom-andersen
suggested changes
Jan 10, 2024
…packages/auth/api-extractor.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the feedback to the count and aggregation API documentation as suggested in #6608.
Ported to Android in firebase/firebase-android-sdk#5634.
Ported to iOS in firebase/firebase-ios-sdk#12254.
Ported to CPP in firebase/firebase-cpp-sdk#1511.
Ported to Unity in firebase/firebase-unity-sdk#923.
Ported to Node server SDK in googleapis/nodejs-firestore#1974.
Ported to Java server SDK in googleapis/java-firestore#1522.