Firestore: FirestoreDataConverter doc and test improvements#7932
Merged
Firestore: FirestoreDataConverter doc and test improvements#7932
Conversation
… of AppModel and DbModel
…ing data could have been written into Firestore
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (d7ace80) and merge commit (574a276).Test Logs |
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (d7ace80) and merge commit (574a276).Test Logs |
dconeybe
changed the title
dconeybe
requested review from
a team,
egilmorez,
kevinthecheung and
markarndt
as code owners
MarkDuckworth
approved these changes
Jan 11, 2024
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
LGTM with suggestions.
… neverCall() function.
MarkDuckworth
approved these changes
Jan 16, 2024
Contributor
MarkDuckworth
left a comment
MarkDuckworth
left a comment
There was a problem hiding this comment.
Big readability improvements across the PR!
Contributor
Author
|
@egilmorez Please review for docs changes. Thanks! |
markarndt
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the documentation and unit tests for
FirestoreDataConverter, based on feedback left on #7310.This PR was ported to the nodejs-firestore sdk in #7932.
Googlers see b/289520317 for details.