Conversation
…lling persistence.shutdown() after a setup failure.
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (7f78362) and merge commit (2ea5742).Test Logs |
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (7f78362) and merge commit (2ea5742).Test Logs |
DellaBitta
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some spurious test failures that get reported if some of the "before" actions of a test fail. Specifically, calling
would throw a
error if the "before" step that initialized the
persistencevariable failed before setting it.Although this isn't a problem, it adds noise to a test failure that may already be difficult enough to debug.
The fix is simple: just conditionally call the method only if the object is defined; that is, change it to