Skip to content

Add check against firestore nightly#7851

Merged
wu-hui merged 3 commits intomasterfrom
wuandy/FirestoreNightly
Dec 11, 2023
Merged

Add check against firestore nightly#7851
wu-hui merged 3 commits intomasterfrom
wuandy/FirestoreNightly

Conversation

@wu-hui
Copy link
Copy Markdown
Contributor

@wu-hui wu-hui commented Dec 11, 2023 •
edited
Loading

This PR adds a new optional check to run Firestore integration tests against Firestore Nightly Environment.

@wu-hui wu-hui requested a review from a team as a code owner December 11, 2023 16:00
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0f48b6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wu-hui wu-hui requested a review from a team as a code owner December 11, 2023 16:05
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Dec 11, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (efa116b) and merge commit (ba19319).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8C3QKkhsca.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Dec 11, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (efa116b) and merge commit (ba19319).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LTwHKkPvdq.html

@wu-hui wu-hui requested a review from DellaBitta December 11, 2023 16:38
DellaBitta
DellaBitta approved these changes Dec 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the pull request summary with details about this change so that if need to look at this PR in the future, it's very obvious to us what it does.

@wu-hui
Copy link
Copy Markdown
Contributor Author

wu-hui commented Dec 11, 2023

Please update the pull request summary with details about this change so that if need to look at this PR in the future, it's very obvious to us what it does.

Done.

@wu-hui wu-hui merged commit 03ba262 into master Dec 11, 2023
@wu-hui wu-hui deleted the wuandy/FirestoreNightly branch December 11, 2023 16:43
@firebase firebase locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees

@DellaBitta DellaBitta

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wu-hui @google-oss-bot @DellaBitta