Conversation
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (fbd8e0e) and merge commit (a99b82b).Test Logs |
wu-hui
approved these changes
Sep 6, 2023
dconeybe
changed the title
dconeybe
deleted the
dconeybe/ClientSideIndexAutoCreationDefaultRelativeIndexReadCostSimpleValue
branch
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (fbd8e0e) and merge commit (a99b82b).Test Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
query_engine.tstheDEFAULT_RELATIVE_INDEX_READ_COST_PER_DOCUMENTvalue was hardcoded as2, which was just copied from the Android SDK. Some experimentation has been done and we found that this value should not be hardcoded universally, but should be adjusted based on the browser/OS on which the code is running. More experiment data is needed, so changing the hardcoded value to8is the lowest-common-denominator of the experiment data captured so far. A later PR will refine this value.