Conversation
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (a6d516d) and merge commit (7e330fc).Test Logs |
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (a6d516d) and merge commit (7e330fc).Test Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Firestore integration tests are parameterized by the persistence type being used. All of the tests accept a
persistenceargument of typeboolean. The tests unnecessarily explicitly specify the typebooleanfor this argument; however, the type can be omitted and deduced by the TypeScript compiler, leading to less code.The immediate motivation of this change is to prepare for changing the type from
booleanto some new type. By removing the explicit specification ofboolean, a future change, #7404, will be able to change the type without actually affecting most of the test code that accepts thepersistenceargument. This will lead to a more targeted diff for that PR.Note to reviewers: This small change reduced some of the line lengths that caused massive indentation changes. Consider turning off whitespace in the diff while reviewing.