Conversation
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (f2fb56f) and merge commit (7e45723).Test Logs |
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (f2fb56f) and merge commit (7e45723).Test Logs |
…ralization [no actions]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of Firestore's integration tests are parameterized with a
persistenceboolean:truemeans to use indexeddb persistence with lru gc andfalsemeans to use memory persistence with eager gc.But as of #6943 we now support memory persistence with lru gc. Some tests (specifically,
resuming a query should use bloom filter to avoid full requery, which is undergoing this change in #7401) can take advantage of this new persistence mode so that it can be run with both memory and indexeddb persistence. However, the integration testing helper methods only use true/false as the persistence mode.This PR generalizes the "persistence mode" from a boolean to a
PersistenceModeobject. This is mostly transparent to the tests as they mostly just "pass through" thepersistenceargument without really caring about its value. However, they were strongly typed asboolean. In this PR the tests were updated to basically ignore the type of thepersistenceargument, except where it mattered.