Skip to content

Firestore: Re-write API docs for COUNT API#6632

Merged
milaGGL merged 6 commits intomila/count-export-count-quriesfrom
dconeybe/CountApiDocs
Sep 27, 2022
Merged

Firestore: Re-write API docs for COUNT API#6632
milaGGL merged 6 commits intomila/count-export-count-quriesfrom
dconeybe/CountApiDocs

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe commented Sep 27, 2022

The wording is copied from firebase/firebase-android-sdk#4143

@dconeybe dconeybe self-assigned this Sep 27, 2022
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 27, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: b5af575

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dconeybe dconeybe changed the base branch from master to mila/count-export-count-quries September 27, 2022 16:06
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Sep 27, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (2d55fc6)Merge (2235c77)Diff
    browser265 kB265 kB-40 B (-0.0%)
    esm5329 kB329 kB-44 B (-0.0%)
    main530 kB530 kB-99 B (-0.0%)
    module265 kB265 kB-40 B (-0.0%)
    react-native265 kB265 kB-40 B (-0.0%)

  • @firebase/firestore-lite

    TypeBase (2d55fc6)Merge (2235c77)Diff
    browser82.1 kB82.1 kB-40 B (-0.0%)
    esm598.3 kB98.3 kB-44 B (-0.0%)
    main139 kB139 kB-99 B (-0.1%)
    module82.1 kB82.1 kB-40 B (-0.0%)
    react-native82.3 kB82.3 kB-40 B (-0.0%)

  • firebase

    TypeBase (2d55fc6)Merge (2235c77)Diff
    firebase-firestore-lite.js87.8 kB87.7 kB-40 B (-0.0%)
    firebase-firestore.js313 kB313 kB-40 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0TSfPZd23a.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Sep 27, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (211,141 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2G7CxiXqBR.html

@github-actions github-actions Bot added the doc-changes PRs that affect docs label Sep 27, 2022
@dconeybe dconeybe marked this pull request as ready for review September 27, 2022 18:35
@dconeybe dconeybe requested review from milaGGL and removed request for dwyfrequency and hsubox76 September 27, 2022 18:35
milaGGL
milaGGL approved these changes Sep 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL merged commit 88d0266 into mila/count-export-count-quries Sep 27, 2022
@milaGGL milaGGL deleted the dconeybe/CountApiDocs branch September 27, 2022 21:13
@dconeybe dconeybe mentioned this pull request Sep 30, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels

api: firestore doc-changes PRs that affect docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @google-oss-bot @milaGGL