Make count queries publicly available for use#6608
Merged
Conversation
* update firestore.proto and query.proto * add aggregation_result.proto
🦋 Changeset detectedLatest commit: 88d0266 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dconeybe
requested changes
Sep 23, 2022
dconeybe
requested changes
Sep 26, 2022
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
One tiny change. Also, please address the problems reported by lint.
Contributor
|
Here's another problem: When I ran This need to be fixed too. |
milaGGL
requested review from
dwyfrequency,
egilmorez and
hsubox76
as code owners
Contributor
|
I've added the do-not-merge label to make sure we don't merge until we get the green light to release count. |
hsubox76
reviewed
Sep 27, 2022
* Fix document change leads to time travel across multiple tabs * Changeset
hsubox76
approved these changes
Sep 27, 2022
dconeybe
changed the title
Merged
egilmorez
reviewed
Oct 3, 2022
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Here are some things that would be great to get into a follow-on PR, thanks!
Contributor
Thanks for the suggestions! I was the one who wrote these doc comments so I'll make the follow-up changes. I'll be tracking this work in b/250612059. |
Contributor
|
Sounds good, thanks Denver!
…On Mon, Oct 3, 2022 at 9:50 AM Denver Coneybeare ***@***.***> wrote:
Here are some things that would be great to get into a follow-on PR,
thanks!
Thanks for the suggestions! I was the one who wrote these doc comments so
I'll make the follow-up changes. I'll be tracking this work in b/250612059
<https://buganizer.corp.google.com/250612059>.
—
Reply to this email directly, view it on GitHub
<#6608 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKJWAYG4QZFBD4E4VCBXC3WBMFF5ANCNFSM6AAAAAAQOQQTQI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR publicly exports the classes, methods, and functions that provide "count" queries, making them available for anyone to use. See #6597 for the implementation of COUNT queries.
Withholding this PR till the count query is ready to be released.