Conversation
* update firestore.proto and query.proto * add aggregation_result.proto
🦋 Changeset detectedLatest commit: 0267c69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1This report is too large (291,554 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
dconeybe
requested changes
Sep 15, 2022
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
Looks great! I had a few ideas that popped up that should have come up in my earlier reviews. PTAL and let me know what you think.
Contributor
Changeset File Check ✅
|
dconeybe
requested changes
Sep 16, 2022
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
Just 2 minor comments then I think we're good!
| '@firebase/firestore': minor | ||
| --- | ||
|
|
||
| Release count query for internal use. |
Contributor
There was a problem hiding this comment.
nit: "Release" -> "Implement"
| ) | ||
| ); | ||
| } | ||
| const result = await getCount(query); |
Contributor
There was a problem hiding this comment.
Lines 529 and 530 still need to be in an "else" block.
dconeybe
approved these changes
Sep 16, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.