Skip to content

Mila/count non lite api tests#6581

Merged
milaGGL merged 6 commits intomila/countfrom
mila/count-non-lite-api-tests
Sep 8, 2022
Merged

Mila/count non lite api tests#6581
milaGGL merged 6 commits intomila/countfrom
mila/count-non-lite-api-tests

Conversation

@milaGGL
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL commented Sep 2, 2022 •
edited
Loading

add tests for :

  • Make sure that the query property of AggregateQuery is === to the query specified to countQuery().
  • Make sure that the query property of AggregateQuerySnapshot is === to the query specified to getAggregateFromServerDirect().
  • count query supports collection group query
  • count query supports query with a converter
  • can't run count query on a terminated Firestore.
  • terminate Firestore won't crash while there is flying count query

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c2c9cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL requested a review from dconeybe September 2, 2022 20:33
@milaGGL milaGGL changed the base branch from master to mila/count September 2, 2022 20:33
milaGGL
milaGGL commented Sep 2, 2022
View reviewed changes
Comment thread packages/firestore/src/core/firestore_client.ts Outdated
dconeybe
dconeybe requested changes Sep 7, 2022
View reviewed changes
Comment thread packages/firestore/src/core/firestore_client.ts Outdated
Comment thread packages/firestore/test/integration/api/aggregation.test.ts Outdated
Comment thread packages/firestore/test/integration/api/aggregation.test.ts Outdated
Comment thread packages/firestore/test/integration/api/aggregation.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
@dconeybe dconeybe removed their assignment Sep 7, 2022
@milaGGL milaGGL requested a review from dconeybe September 7, 2022 05:07
dconeybe
dconeybe reviewed Sep 7, 2022
View reviewed changes
Comment thread packages/firestore/test/integration/util/helpers.ts
@milaGGL milaGGL requested a review from dconeybe September 7, 2022 16:54
@milaGGL milaGGL merged commit 98189d5 into mila/count Sep 8, 2022
@milaGGL milaGGL deleted the mila/count-non-lite-api-tests branch September 8, 2022 15:57
@firebase firebase locked and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milaGGL @dconeybe