Skip to content

change int32 to int64#6577

Merged
milaGGL merged 2 commits intomila/countfrom
mila/count-update-proto_upto
Sep 2, 2022
Merged

change int32 to int64#6577
milaGGL merged 2 commits intomila/countfrom
mila/count-update-proto_upto

Conversation

@milaGGL
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL commented Aug 31, 2022

change int32 to int64 for up_to

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 31, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2c667fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL requested a review from dconeybe August 31, 2022 20:46
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Aug 31, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (a3242ce)Merge (1528a8a)Diff
    main530 kB530 kB+21 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5u4PSDGseG.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Aug 31, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (a3242ce) and merge commit (1528a8a).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fSaQHTXRqb.html

dconeybe
dconeybe reviewed Sep 1, 2022
View reviewed changes
Comment thread packages/firestore/src/protos/google/firestore/v1/query.proto Outdated
//
// * Must be greater than zero when present.
int32 up_to = 1;
int64 up_to = 1;
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be google.protobuf.Int64Value.

See firebase/firebase-android-sdk#4038

Copy link
Copy Markdown
Contributor Author

@milaGGL milaGGL Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have google.protobuf.Int64Value in web sdk?
web sdk used google.protobuf.Int32Value, but didn't see any line uses google.protobuf.Int64Value. 🤔

Copy link
Copy Markdown
Contributor

@dconeybe dconeybe Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe we do have google.protobuf.Int64Value in the web sdk. Even if we don't it's fine because we never use it. But it's important that the proto definition is correct because if we ever do use it in the future then we want it to work correctly. Are you encountering errors when you change it to Int64Value?

Copy link
Copy Markdown
Contributor Author

@milaGGL milaGGL Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, no errors

dconeybe
dconeybe requested changes Sep 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to run that command from update.sh to regenerate the code from the changed protos.

@milaGGL milaGGL requested a review from dconeybe September 1, 2022 17:25
@milaGGL milaGGL merged commit fe871ce into mila/count Sep 2, 2022
@milaGGL milaGGL deleted the mila/count-update-proto_upto branch September 2, 2022 16:41
@firebase firebase locked and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@dconeybe dconeybe

@milaGGL milaGGL

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milaGGL @google-oss-bot @dconeybe