Update type of ParsedToken to include unknown#6569
Merged
Conversation
sam-gc
requested review from
avolkovi,
dwyfrequency,
hsubox76,
lisajian and
yuchenshi
as code owners
🦋 Changeset detectedLatest commit: a3ef14c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected ProductsNo changes between base commit (b993aee) and merge commit (31f5c99).Test Logs |
lisajian
approved these changes
Aug 26, 2022
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (b993aee) and merge commit (31f5c99).Test Logs |
prameshj
approved these changes
Aug 26, 2022
kevinthecheung
approved these changes
Aug 26, 2022
hsubox76
approved these changes
Sep 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the type of the custom claim field in the
ParsedTokeninterface to beany. This more accurately reflects that a JWT may contain any valid JSON object.While using the
unknowntype would have been more type-safe (and use ofanyis generally frowned-upon), it unfortunately makes this change backwards-incompatible.Fixes #6553