Skip to content

Mila/count add tests#6566

Merged
milaGGL merged 10 commits intomila/countfrom
mila/count-add-tests
Aug 30, 2022
Merged

Mila/count add tests#6566
milaGGL merged 10 commits intomila/countfrom
mila/count-add-tests

Conversation

@milaGGL
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL commented Aug 25, 2022 •
edited
Loading

tasks:

  • add test case for orderBy
  • add test case for startAt, startAfter
  • add test case for endAt, endBefore
  • add test case for collection group
  • add test case for running count query on terminated firestore instance

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 25, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: db7a85b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL changed the base branch from master to mila/count August 25, 2022 20:10
@milaGGL milaGGL requested review from dconeybe and removed request for dwyfrequency and hsubox76 August 25, 2022 20:10
milaGGL
milaGGL commented Aug 25, 2022
View reviewed changes
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Aug 25, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (c21304b) and merge commit (2f64a6e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kERuWOC6bB.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Aug 25, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (c21304b) and merge commit (2f64a6e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6CkiBwWcaf.html

dconeybe
dconeybe requested changes Aug 26, 2022
View reviewed changes
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
@milaGGL milaGGL requested a review from dconeybe August 26, 2022 17:37
@dconeybe dconeybe removed their assignment Aug 26, 2022
@milaGGL milaGGL merged commit a3242ce into mila/count Aug 30, 2022
@milaGGL milaGGL deleted the mila/count-add-tests branch August 30, 2022 17:59
@firebase firebase locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milaGGL @google-oss-bot @dconeybe