Skip to content

Mila/count implement count query#6528

Merged
milaGGL merged 25 commits intomila/countfrom
mila/count-implement-count-query
Aug 24, 2022
Merged

Mila/count implement count query#6528
milaGGL merged 25 commits intomila/countfrom
mila/count-implement-count-query

Conversation

@milaGGL
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL commented Aug 12, 2022 •
edited
Loading

task

task flow: https://taskflow.corp.google.com/workspaces/483058/iterations/2541152?edit=b%2F240311268

TODO:

  • implement getAggregateFromServerDirect function that provides count result
  • implement invokeRunAggregationQueryRpc to wire up aggregation query rpc requests
  • make the integration test pass for count query without filter

--added limit, filter and their integration test
-- tested out the converter impact on AggregateQuery type as well

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 12, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1a0cce3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@milaGGL milaGGL changed the base branch from master to mila/count August 12, 2022 19:46
@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Aug 12, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (981e6f1)Merge (0177c4f)Diff
    browser264 kB265 kB+1.05 kB (+0.4%)
    esm5327 kB329 kB+1.27 kB (+0.4%)
    main528 kB530 kB+1.87 kB (+0.4%)
    module264 kB265 kB+1.05 kB (+0.4%)
    react-native264 kB265 kB+1.05 kB (+0.4%)

  • @firebase/firestore-lite

    TypeBase (981e6f1)Merge (0177c4f)Diff
    browser80.5 kB80.6 kB+42 B (+0.1%)
    esm596.2 kB96.3 kB+42 B (+0.0%)
    main135 kB135 kB+66 B (+0.0%)
    module80.5 kB80.6 kB+42 B (+0.1%)
    react-native80.7 kB80.7 kB+42 B (+0.1%)

  • bundle

    12 size changes

    TypeBase (981e6f1)Merge (0177c4f)Diff
    firestore (Persistence)274 kB274 kB+68 B (+0.0%)
    firestore (Query Cursors)211 kB211 kB+68 B (+0.0%)
    firestore (Query)212 kB212 kB+68 B (+0.0%)
    firestore (Read data once)200 kB200 kB+68 B (+0.0%)
    firestore (Realtime updates)202 kB202 kB+68 B (+0.0%)
    firestore (Transaction)184 kB184 kB+68 B (+0.0%)
    firestore (Write data)184 kB184 kB+68 B (+0.0%)
    firestore-lite (Query Cursors)67.9 kB68.0 kB+42 B (+0.1%)
    firestore-lite (Query)71.1 kB71.1 kB+42 B (+0.1%)
    firestore-lite (Read data once)55.5 kB55.5 kB+42 B (+0.1%)
    firestore-lite (Transaction)80.1 kB80.1 kB+42 B (+0.1%)
    firestore-lite (Write data)65.3 kB65.3 kB+42 B (+0.1%)

  • firebase

    TypeBase (981e6f1)Merge (0177c4f)Diff
    firebase-compat.js794 kB794 kB+40 B (+0.0%)
    firebase-firestore-compat.js314 kB314 kB+40 B (+0.0%)
    firebase-firestore-lite.js267 kB267 kB+48 B (+0.0%)
    firebase-firestore.js853 kB855 kB+2.16 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9RtsfBzz3E.html

@google-oss-bot
Copy link
Copy Markdown
Collaborator

google-oss-bot commented Aug 12, 2022 •
edited
Loading

Size Analysis Report 1

This report is too large (423,103 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uTtfRLCzbc.html

@github-actions github-actions Bot added the doc-changes PRs that affect docs label Aug 12, 2022
@milaGGL milaGGL marked this pull request as ready for review August 17, 2022 01:56
@milaGGL milaGGL requested a review from ehsannas August 17, 2022 17:55
milaGGL
milaGGL commented Aug 17, 2022
View reviewed changes
Comment thread packages/firestore/src/lite-api/aggregate.ts
milaGGL
milaGGL commented Aug 17, 2022
View reviewed changes
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
milaGGL
milaGGL commented Aug 17, 2022
View reviewed changes
Comment thread packages/firestore/src/remote/datastore.ts
milaGGL
milaGGL commented Aug 17, 2022
View reviewed changes
Comment thread packages/firestore/src/remote/serializer.ts
@milaGGL milaGGL requested a review from dconeybe August 18, 2022 21:35
dconeybe
dconeybe requested changes Aug 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've left some feedback.

Comment thread packages/firestore/src/lite-api/aggregate.ts
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts
@milaGGL milaGGL requested a review from dconeybe August 23, 2022 20:13
dconeybe
dconeybe requested changes Aug 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor cleanups.

Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
Comment thread packages/firestore/test/lite/integration.test.ts Outdated
@milaGGL milaGGL requested a review from dconeybe August 24, 2022 18:28
dconeybe
dconeybe requested changes Aug 24, 2022
View reviewed changes
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
Comment thread packages/firestore/src/lite-api/aggregate.ts Outdated
@milaGGL milaGGL requested a review from dconeybe August 24, 2022 20:04
dconeybe
dconeybe approved these changes Aug 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Yay! 🎉

@milaGGL milaGGL merged commit bc61df7 into mila/count Aug 24, 2022
@milaGGL milaGGL deleted the mila/count-implement-count-query branch August 24, 2022 20:41
@firebase firebase locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@egilmorez egilmorez

@dconeybe dconeybe

@milaGGL milaGGL

Labels

doc-changes PRs that affect docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@milaGGL @google-oss-bot @dconeybe @ehsannas @egilmorez