Tomandersen/multi db by tom-andersen · Pull Request #6518 · firebase/firebase-js-sdk

tom-andersen · 2022-08-08T19:50:55Z

Add Firestore named DB support.

…into tomandersen/multiDb

changeset-bot · 2022-08-08T19:50:58Z

🦋 Changeset detected

Latest commit: 5c8a2fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Minor
@firebase/firestore-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-08-08T19:52:46Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2022-08-08T20:14:24Z

Size Report ¹

Affected Products

@firebase/firestore
Type Base (f88805e) Merge (404571a) Diff
browser 264 kB 264 kB +194 B (+0.1%)
esm5 327 kB 327 kB +178 B (+0.1%)
main 525 kB 525 kB +378 B (+0.1%)
module 264 kB 264 kB +194 B (+0.1%)
react-native 264 kB 264 kB +194 B (+0.1%)

`@firebase/firestore-lite`

Type	Base (`f88805e`)	Merge (404571a)	Diff
browser	80.7 kB	80.8 kB	+146 B (+0.2%)
esm5	96.5 kB	96.6 kB	+130 B (+0.1%)
main	136 kB	136 kB	+308 B (+0.2%)
module	80.7 kB	80.8 kB	+146 B (+0.2%)
react-native	80.9 kB	81.0 kB	+146 B (+0.2%)

`bundle`

12 size changes

Type	Base (`f88805e`)	Merge (404571a)	Diff
firestore (Persistence)	274 kB	274 kB	+113 B (+0.0%)
firestore (Query Cursors)	211 kB	211 kB	+113 B (+0.1%)
firestore (Query)	212 kB	212 kB	+113 B (+0.1%)
firestore (Read data once)	200 kB	201 kB	+113 B (+0.1%)
firestore (Realtime updates)	203 kB	203 kB	+113 B (+0.1%)
firestore (Transaction)	184 kB	184 kB	+113 B (+0.1%)
firestore (Write data)	184 kB	184 kB	+113 B (+0.1%)
firestore-lite (Query Cursors)	68.2 kB	68.3 kB	+102 B (+0.1%)
firestore-lite (Query)	71.4 kB	71.5 kB	+102 B (+0.1%)
firestore-lite (Read data once)	55.8 kB	55.9 kB	+102 B (+0.2%)
firestore-lite (Transaction)	80.3 kB	80.4 kB	+102 B (+0.1%)
firestore-lite (Write data)	65.5 kB	65.6 kB	+102 B (+0.2%)

`firebase`

Type	Base (`f88805e`)	Merge (404571a)	Diff
firebase-compat.js	738 kB	739 kB	+30 B (+0.0%)
firebase-firestore-compat.js	314 kB	314 kB	+30 B (+0.0%)
firebase-firestore-lite.js	86.1 kB	86.2 kB	+145 B (+0.2%)
firebase-firestore.js	312 kB	313 kB	+194 B (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/9HeVDJFSu4.html

google-oss-bot · 2022-08-08T20:28:59Z

Size Analysis Report ¹

Affected Products

@firebase/firestore
- AbstractUserDataWriter
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 24.1 kB 24.1 kB +31 B (+0.1%)
  size-with-ext-deps 83.6 kB 83.6 kB +30 B (+0.0%)
- Bytes
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.6 kB 17.6 kB +31 B (+0.2%)
  size-with-ext-deps 77.1 kB 77.1 kB +30 B (+0.0%)
- CACHE_SIZE_UNLIMITED
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- CollectionReference
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 19.9 kB 20.0 kB +31 B (+0.2%)
  size-with-ext-deps 79.4 kB 79.4 kB +30 B (+0.0%)
- DocumentReference
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 19.9 kB 20.0 kB +31 B (+0.2%)
  size-with-ext-deps 79.4 kB 79.4 kB +30 B (+0.0%)
- DocumentSnapshot
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 23.4 kB 23.4 kB +31 B (+0.1%)
  size-with-ext-deps 82.9 kB 82.9 kB +30 B (+0.0%)
- FieldPath
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 19.0 kB 19.1 kB +31 B (+0.2%)
  size-with-ext-deps 78.5 kB 78.5 kB +30 B (+0.0%)
- FieldValue
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.9 kB +30 B (+0.0%)
- Firestore
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.3 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- FirestoreError
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.3 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- GeoPoint
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.9 kB 16.9 kB +31 B (+0.2%)
  size-with-ext-deps 76.4 kB 76.4 kB +30 B (+0.0%)
- LoadBundleTask
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.2 kB 17.2 kB +31 B (+0.2%)
  size-with-ext-deps 76.6 kB 76.7 kB +30 B (+0.0%)
- Query
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.5 kB 16.5 kB +31 B (+0.2%)
  size-with-ext-deps 75.9 kB 76.0 kB +30 B (+0.0%)
- QueryConstraint
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.3 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- QueryDocumentSnapshot
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 23.4 kB 23.4 kB +31 B (+0.1%)
  size-with-ext-deps 82.9 kB 82.9 kB +30 B (+0.0%)
- QuerySnapshot
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 25.3 kB 25.3 kB +31 B (+0.1%)
  size-with-ext-deps 84.8 kB 84.8 kB +30 B (+0.0%)
- SnapshotMetadata
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.5 kB 16.5 kB +31 B (+0.2%)
  size-with-ext-deps 75.9 kB 76.0 kB +30 B (+0.0%)
- Timestamp
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.5 kB 17.6 kB +31 B (+0.2%)
  size-with-ext-deps 77.0 kB 77.0 kB +30 B (+0.0%)
- Transaction
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 49.7 kB 49.7 kB +30 B (+0.1%)
  size-with-ext-deps 109 kB 109 kB +30 B (+0.0%)
- WriteBatch
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 46.5 kB 46.5 kB +30 B (+0.1%)
  size-with-ext-deps 106 kB 106 kB +30 B (+0.0%)
- _DatabaseId
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.3 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- _DocumentKey
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 25.6 kB 25.6 kB +31 B (+0.1%)
  size-with-ext-deps 85.1 kB 85.1 kB +30 B (+0.0%)
- _EmptyAppCheckTokenProvider
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.5 kB +31 B (+0.2%)
  size-with-ext-deps 75.9 kB 75.9 kB +30 B (+0.0%)
- _EmptyAuthCredentialsProvider
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- _FieldPath
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 18.8 kB 18.8 kB +31 B (+0.2%)
  size-with-ext-deps 78.2 kB 78.3 kB +30 B (+0.0%)
- _cast
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.1 kB 17.1 kB +31 B (+0.2%)
  size-with-ext-deps 76.6 kB 76.6 kB +30 B (+0.0%)
- _debugAssert
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- _isBase64Available
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.9 kB +30 B (+0.0%)
- _logWarn
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.5 kB +31 B (+0.2%)
  size-with-ext-deps 75.9 kB 75.9 kB +30 B (+0.0%)
- _validateIsNotUsedTogether
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.3 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- addDoc
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 116 kB 116 kB +30 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +30 B (+0.0%)
- arrayRemove
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 28.7 kB 28.7 kB +31 B (+0.1%)
  size-with-ext-deps 88.3 kB 88.3 kB +30 B (+0.0%)
- arrayUnion
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 28.7 kB 28.7 kB +31 B (+0.1%)
  size-with-ext-deps 88.3 kB 88.3 kB +30 B (+0.0%)
- clearIndexedDbPersistence
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 25.1 kB 25.1 kB +31 B (+0.1%)
  size-with-ext-deps 84.7 kB 84.8 kB +30 B (+0.0%)
- collection
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 20.6 kB 20.7 kB +31 B (+0.2%)
  size-with-ext-deps 80.2 kB 80.2 kB +30 B (+0.0%)
- collectionGroup
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 19.7 kB 19.7 kB +31 B (+0.2%)
  size-with-ext-deps 79.1 kB 79.2 kB +30 B (+0.0%)
- connectFirestoreEmulator
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 18.1 kB 18.2 kB +31 B (+0.2%)
  size-with-ext-deps 78.2 kB 78.2 kB +30 B (+0.0%)
- deleteDoc
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 107 kB 107 kB +30 B (+0.0%)
  size-with-ext-deps 168 kB 168 kB +30 B (+0.0%)
- deleteField
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.7 kB 16.8 kB +31 B (+0.2%)
  size-with-ext-deps 76.2 kB 76.2 kB +30 B (+0.0%)
- disableNetwork
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 95.7 kB 95.8 kB +30 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +30 B (+0.0%)
- doc
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 20.7 kB 20.7 kB +31 B (+0.1%)
  size-with-ext-deps 80.2 kB 80.3 kB +30 B (+0.0%)
- documentId
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 19.1 kB 19.1 kB +31 B (+0.2%)
  size-with-ext-deps 78.5 kB 78.6 kB +30 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 174 kB 174 kB +30 B (+0.0%)
  size-with-ext-deps 235 kB 235 kB +30 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 207 kB 207 kB +30 B (+0.0%)
  size-with-ext-deps 268 kB 268 kB +30 B (+0.0%)
- enableNetwork
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 95.7 kB 95.7 kB +30 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +30 B (+0.0%)
- endAt
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 34.7 kB 34.7 kB +31 B (+0.1%)
  size-with-ext-deps 94.2 kB 94.3 kB +30 B (+0.0%)
- endBefore
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 34.7 kB 34.7 kB +31 B (+0.1%)
  size-with-ext-deps 94.2 kB 94.3 kB +30 B (+0.0%)
- ensureFirestoreConfigured
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.5 kB 16.5 kB +31 B (+0.2%)
  size-with-ext-deps 75.9 kB 75.9 kB +30 B (+0.0%)
- executeWrite
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 106 kB 106 kB +30 B (+0.0%)
  size-with-ext-deps 167 kB 167 kB +30 B (+0.0%)
- getDoc
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 132 kB 132 kB +30 B (+0.0%)
  size-with-ext-deps 193 kB 193 kB +30 B (+0.0%)
- getDocFromCache
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 88.8 kB 88.8 kB +30 B (+0.0%)
  size-with-ext-deps 149 kB 149 kB +30 B (+0.0%)
- getDocFromServer
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 132 kB 132 kB +30 B (+0.0%)
  size-with-ext-deps 193 kB 193 kB +30 B (+0.0%)
- getDocs
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 134 kB 134 kB +30 B (+0.0%)
  size-with-ext-deps 195 kB 195 kB +30 B (+0.0%)
- getDocsFromCache
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 96.3 kB 96.3 kB +30 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +30 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 134 kB 134 kB +30 B (+0.0%)
  size-with-ext-deps 195 kB 195 kB +30 B (+0.0%)
- getFirestore
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.5 kB +114 B (+0.7%)
  size-with-ext-deps 76.1 kB 76.2 kB +113 B (+0.1%)
- increment
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.2 kB 17.2 kB +31 B (+0.2%)
  size-with-ext-deps 76.6 kB 76.7 kB +30 B (+0.0%)
- initializeFirestore
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.0 kB 17.1 kB +89 B (+0.5%)
  size-with-ext-deps 76.9 kB 77.0 kB +88 B (+0.1%)
- limit
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.2 kB 17.2 kB +31 B (+0.2%)
  size-with-ext-deps 76.7 kB 76.7 kB +30 B (+0.0%)
- limitToLast
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 17.2 kB 17.2 kB +31 B (+0.2%)
  size-with-ext-deps 76.7 kB 76.7 kB +30 B (+0.0%)
- loadBundle
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 105 kB 105 kB +30 B (+0.0%)
  size-with-ext-deps 165 kB 166 kB +30 B (+0.0%)
- namedQuery
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 82.2 kB 82.3 kB +30 B (+0.0%)
  size-with-ext-deps 142 kB 142 kB +30 B (+0.0%)
- onSnapshot
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 135 kB 135 kB +30 B (+0.0%)
  size-with-ext-deps 195 kB 195 kB +30 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 124 kB 124 kB +30 B (+0.0%)
  size-with-ext-deps 185 kB 185 kB +30 B (+0.0%)
- orderBy
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 21.5 kB 21.5 kB +31 B (+0.1%)
  size-with-ext-deps 81.0 kB 81.0 kB +30 B (+0.0%)
- query
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.9 kB +30 B (+0.0%)
- queryEqual
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 26.1 kB 26.1 kB +31 B (+0.1%)
  size-with-ext-deps 85.6 kB 85.6 kB +30 B (+0.0%)
- refEqual
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 20.1 kB 20.1 kB +31 B (+0.2%)
  size-with-ext-deps 79.6 kB 79.7 kB +30 B (+0.0%)
- runTransaction
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 116 kB 116 kB +30 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +30 B (+0.0%)
- serverTimestamp
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.6 kB 16.7 kB +31 B (+0.2%)
  size-with-ext-deps 76.1 kB 76.1 kB +30 B (+0.0%)
- setDoc
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 115 kB 115 kB +30 B (+0.0%)
  size-with-ext-deps 176 kB 176 kB +30 B (+0.0%)
- setIndexConfiguration
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 84.9 kB 84.9 kB +30 B (+0.0%)
  size-with-ext-deps 145 kB 145 kB +30 B (+0.0%)
- setLogLevel
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.4 kB +31 B (+0.2%)
  size-with-ext-deps 75.8 kB 75.8 kB +30 B (+0.0%)
- snapshotEqual
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 32.9 kB 32.9 kB +31 B (+0.1%)
  size-with-ext-deps 92.4 kB 92.4 kB +30 B (+0.0%)
- startAfter
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 34.7 kB 34.7 kB +31 B (+0.1%)
  size-with-ext-deps 94.2 kB 94.3 kB +30 B (+0.0%)
- startAt
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 34.7 kB 34.7 kB +31 B (+0.1%)
  size-with-ext-deps 94.2 kB 94.3 kB +30 B (+0.0%)
- terminate
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 16.4 kB 16.5 kB +54 B (+0.3%)
  size-with-ext-deps 76.1 kB 76.1 kB +53 B (+0.1%)
- updateDoc
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 116 kB 116 kB +30 B (+0.0%)
  size-with-ext-deps 177 kB 177 kB +30 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 96.2 kB 96.2 kB +30 B (+0.0%)
  size-with-ext-deps 157 kB 157 kB +30 B (+0.0%)
- where
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 41.1 kB 41.1 kB +31 B (+0.1%)
  size-with-ext-deps 101 kB 101 kB +30 B (+0.0%)
- writeBatch
  Size
  Type Base (f88805e) Merge (404571a) Diff
  size 118 kB 118 kB +30 B (+0.0%)
  size-with-ext-deps 179 kB 179 kB +30 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/GmuMKo8c9x.html

wu-hui

Nice PR. Mostly nits and requests to add more tests.

…into tomandersen/multiDb

This reverts commit 0361bf3.

This reverts commit 474025c.

* Revert "Revert "Tomandersen/multi db (#6518)" (#6552)" This reverts commit 474025c. * Make multidb internal for now * Changeset * Delete change log

tom-andersen added 4 commits August 2, 2022 15:08

Multi DB Work In Progress

db85658

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

9ea22ae

…into tomandersen/multiDb

Work in progress

b13378b

MultiDb with Tests.

ce6cf1d

tom-andersen added 2 commits August 8, 2022 15:57

Fix linting

1546ce6

Fix linting

36b774f

Undo package.json change.

21be348

Changset for Multi-DB support

3aaa0ea

tom-andersen assigned wu-hui Aug 9, 2022

tom-andersen requested a review from wu-hui August 9, 2022 14:41

tom-andersen marked this pull request as ready for review August 9, 2022 14:41

tom-andersen requested review from dwyfrequency, egilmorez and hsubox76 as code owners August 9, 2022 14:41

wu-hui reviewed Aug 10, 2022

View reviewed changes

wu-hui assigned tom-andersen and unassigned wu-hui Aug 10, 2022

Add more multi-db tests, and fix a few bugs related to multi-db.

79e31d0

tom-andersen assigned wu-hui and unassigned tom-andersen Aug 11, 2022

tom-andersen added 2 commits August 10, 2022 21:33

Expose API

6291938

Fix integration test

a8b28d2

github-actions Bot added the doc-changes PRs that affect docs label Aug 11, 2022

github-actions Bot assigned egilmorez Aug 11, 2022

tom-andersen added 2 commits August 10, 2022 23:36

Fix import

5f6159e

Fix test

2f955f8

tom-andersen added 2 commits August 11, 2022 09:43

Whitespace

ff7ec24

Only use emulator for integration tests.

05e813f

wu-hui approved these changes Aug 15, 2022

View reviewed changes

Comment thread packages/firestore/test/integration/util/helpers.ts Outdated

Comment thread packages/firestore/test/integration/util/helpers.ts Outdated

wu-hui assigned tom-andersen and unassigned wu-hui Aug 15, 2022

tom-andersen added 3 commits August 22, 2022 11:07

Improve comments and function naming.

ab45518

Merge branch 'master' of https://github.com/firebase/firebase-js-sdk …

04497df

…into tomandersen/multiDb

Make pretty

5c8a2fb

hsubox76 approved these changes Aug 22, 2022

View reviewed changes

tom-andersen merged commit 0361bf3 into master Aug 22, 2022

tom-andersen deleted the tomandersen/multiDb branch August 22, 2022 19:18

wu-hui added a commit that referenced this pull request Aug 23, 2022

Revert "Tomandersen/multi db (#6518)"

e94e4be

This reverts commit 0361bf3.

wu-hui mentioned this pull request Aug 23, 2022

Revert "Tomandersen/multi db" #6552

Merged

wu-hui added a commit that referenced this pull request Aug 23, 2022

Revert "Tomandersen/multi db (#6518)" (#6552)

474025c

This reverts commit 0361bf3.

wu-hui added a commit that referenced this pull request Aug 23, 2022

Revert "Revert "Tomandersen/multi db (#6518)" (#6552)"

3ba02a0

This reverts commit 474025c.

firebase locked and limited conversation to collaborators Sep 22, 2022

Conversation

tom-andersen commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset File Check ✅

Uh oh!

google-oss-bot commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/firestore

@firebase/firestore-lite

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/firestore

AbstractUserDataWriter

Bytes

CACHE_SIZE_UNLIMITED

CollectionReference

DocumentReference

DocumentSnapshot

FieldPath

FieldValue

Firestore

FirestoreError

GeoPoint

LoadBundleTask

Query

QueryConstraint

QueryDocumentSnapshot

QuerySnapshot

SnapshotMetadata

Timestamp

Transaction

WriteBatch

_DatabaseId

_DocumentKey

_EmptyAppCheckTokenProvider

_EmptyAuthCredentialsProvider

_FieldPath

_cast

_debugAssert

_isBase64Available

_logWarn

_validateIsNotUsedTogether

addDoc

arrayRemove

arrayUnion

clearIndexedDbPersistence

collection

collectionGroup

connectFirestoreEmulator

deleteDoc

deleteField

disableNetwork

doc

documentId

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

endAt

endBefore

ensureFirestoreConfigured

executeWrite

getDoc

getDocFromCache

getDocFromServer

getDocs

tom-andersen commented Aug 8, 2022 •

edited

Loading

changeset-bot Bot commented Aug 8, 2022 •

edited

Loading

github-actions Bot commented Aug 8, 2022 •

edited

Loading

google-oss-bot commented Aug 8, 2022 •

edited

Loading

Size Report ¹

`@firebase/firestore`

`@firebase/firestore-lite`

`bundle`

`firebase`

google-oss-bot commented Aug 8, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/firestore`

`AbstractUserDataWriter`

`Bytes`

`CACHE_SIZE_UNLIMITED`

`CollectionReference`

`DocumentReference`

`DocumentSnapshot`

`FieldPath`

`FieldValue`

`Firestore`

`FirestoreError`

`GeoPoint`

`LoadBundleTask`

`Query`

`QueryConstraint`

`QueryDocumentSnapshot`

`QuerySnapshot`

`SnapshotMetadata`

`Timestamp`

`Transaction`

`WriteBatch`

`_DatabaseId`

`_DocumentKey`

`_EmptyAppCheckTokenProvider`

`_EmptyAuthCredentialsProvider`

`_FieldPath`

`_cast`

`_debugAssert`

`_isBase64Available`

`_logWarn`

`_validateIsNotUsedTogether`

`addDoc`

`arrayRemove`

`arrayUnion`

`clearIndexedDbPersistence`

`collection`

`collectionGroup`

`connectFirestoreEmulator`

`deleteDoc`

`deleteField`

`disableNetwork`

`doc`

`documentId`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`endAt`

`endBefore`

`ensureFirestoreConfigured`

`executeWrite`

`getDoc`

`getDocFromCache`

`getDocFromServer`

`getDocs`

`getDocsFromCache`

`getDocsFromServer`

`getFirestore`

`increment`

`initializeFirestore`

`limit`

`limitToLast`

`loadBundle`

`namedQuery`

`onSnapshot`

`onSnapshotsInSync`

`orderBy`

`query`

`queryEqual`

`refEqual`