compile protos and upload the generated json file#6491
Conversation
|
| "type": "string", | ||
| "id": 1, | ||
| "options": { | ||
| "(google.api.field_behavior)": "REQUIRED" |
There was a problem hiding this comment.
proto3 deprecated the "required". This should be a tag only, wouldn't have any side effects, right? 🤔
There was a problem hiding this comment.
I don't know what effects it has, to be honest. But it is definitely different from proto2's "required" keyword. You can just assume it's correct since it's used elsewhere in the protos.
|
wonder why this PR doesn't have compiled proto files in it: https://github.com/firebase/firebase-android-sdk/pull/3847/files CodeLab said it should generate java files when compile protos: https://g3doc.corp.google.com/codelab/protocolbuffers/g3doc/java.md?cl=head#compiler-output:~:text=with%20the%20option%20java_multiple_files%20%3D%20true%2C%20the%20compiler%20generates%20a%20.java%20file%20for%20each%20message%20in%20each%20. |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (b92e492) and merge commit (4c05097).Test Logs |
That is because the Android build system will compile the .proto files into .java files at build time. Our TypeScript build setup does not have that feature. Therefore, we need to compile the protos manually and check them into source control. |
3 participants
compiled the proto files added/created and add the proto.json file that is generated.