Mila/count update proto#6482
Merged
milaGGL merged 7 commits intomila/countfrom Jul 28, 2022
Merged
Conversation
|
Collaborator
Size Report 1Affected ProductsNo changes between base commit (f5426a5) and merge commit (f2b51cb).Test Logs |
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (f5426a5) and merge commit (f2b51cb).Test Logs |
milaGGL
commented
Jul 28, 2022
dconeybe
requested changes
Jul 28, 2022
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
Great job! I've left a few minor comments to address.
milaGGL
commented
Jul 28, 2022
dconeybe
requested changes
Jul 28, 2022
dconeybe
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proto is updated based on the changes in this PR: firebase/firebase-android-sdk#3847